Chart: Render controller.ingressClassResource.parameters natively.

[Gacko]

What this PR does / why we need it:

At the moment there is a named template for rendering the IngressClass parameters. According to my tests, this is not required and can be replaced by better readable native rendering directly in the template file.

Ingress NGINX right now does not support such parameters, but still we can keep them if we want to in the future. Because of this, there's quite little risk of breaking something in this change.

The only scenario I can imagine is someone overriding the named template in their custom _helpers.tpl and (also) using the IngressClass provided by our chart for a different Ingress Controller which supports parameters. That's a risk I can accept.

At the moment of filing this PR, there's another one open, not yet merged PR: #11104. This PR here relies on that PR and therefore should only be merge after the other one.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

How Has This Been Tested?

Diffing helm template, implementing unit tests.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	41a6661
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65f074acc9b49d0009d7d0a6

[Gacko]

/assign
/priority backlog
/kind bug
/triage accepted

[Gacko]

/cherry-pick release-1.10

[k8s-infra-cherrypick-robot]

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Gacko]

cc @rikatz for review

[rikatz]

/cc

[rikatz]

Great catch. I agree this is a simple one, should not break anything 🙏

/lgtm
/approve

Thanks!!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [Gacko,rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@Gacko: new pull request created: #11126

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.