Rename projectinformer to filteredinformer #2755
Merged
+432
−432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
panslava
force-pushed
the
rename-informer
branch
from
153a4e5 to
745ecb7
Compare
panslava
force-pushed
the
rename-informer
branch
2 times, most recently
from
231e4b1 to
8b8e83e
Compare
|
/retest |
|
tests failing with 'ERROR: failed to acquire GCP project. boskos response was: Acquire failed: no available resource gce-project, try again later.' |
|
/retest |
k8s-ci-robot
added
the
needs-rebase
panslava
force-pushed
the
rename-informer
branch
from
8b8e83e to
bcf25aa
Compare
k8s-ci-robot
removed
the
needs-rebase
|
I'm guessing that unfortunately, this needs another round of renaming? |
|
(This is also LGTM, pending renaming) |
panslava
force-pushed
the
rename-informer
branch
from
bcf25aa to
a2df032
Compare
k8s-ci-robot
added
size/XXL
|
renamed to provider config, ready for re-review @gauravkghildiyal |
panslava
force-pushed
the
rename-informer
branch
from
a2df032 to
f598989
Compare
k8s-ci-robot
added
size/XL
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we added ClusterSlice now, let's rename projectinformer to filteredinformer which will filter based on cluster slice name label
/assign @gauravkghildiyal