Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function that starts NEG controller per ProviderConfig #2729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add function that starts NEG controller per ProviderConfig #2729

wants to merge 1 commit into from

Conversation

panslava
Copy link
Contributor

@panslava panslava commented Nov 5, 2024 •
edited
Loading

  • Will be used with ProviderConfig Controller, starting NEG controller as
    ProviderConfig EventHandler

based on other PR #2755

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 5, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 3, 2024
@panslava panslava force-pushed the multi-project-neg branch 3 times, most recently from 2560ae5 to 7d2a218 Compare December 5, 2024 00:11
@panslava
Copy link
Contributor Author

panslava commented Dec 6, 2024

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2024
@panslava panslava force-pushed the multi-project-neg branch 2 times, most recently from e0f74d7 to c1adda5 Compare December 13, 2024 07:33
@panslava panslava changed the title Add function that starts NEG controller per Project Add function that starts NEG controller per ProviderConfig Dec 13, 2024
@panslava
Add function that starts NEG controller per ProviderConfig
412d436 
- Will be used with ProviderConfig Controller, starting NEG controller as
  ProviderConfig EventHandler
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@sawsa307 sawsa307 Awaiting requested review from sawsa307

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panslava @k8s-ci-robot