Neg count metrics #2177
Neg count metrics #2177
Conversation
* track neg count by location and endpoint type * other neg usage only track number of service points while this will give a more accurate reading for regional clusters
|
@swetharepakula: GitHub didn't allow me to request PR reviews from the following users: sawsa307. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
cncf-cla: yes
|
LGTM, thank you for making this change! |
* removes need for hardcoding all states
swetharepakula
force-pushed
the
neg-count-metrics
branch
from
7e97fee to
761d57c
Compare
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a new managed neg count metric that will track the count of negs by zone and endpoint type. This is different from the neg count in the usage metrics which only counts syncers. The usage metrics can be an undercount as it does not account for regional clusters where a neg is created per zone. Syncers' locations can point to regions for regional clusters which does not give an accurate picture of the distribution of negs across zones.
A followup commit is also included that cleans up the syncerState metric so that the different states no longer need to be hardcoded.
/assign @gauravkghildiyal
/cc @sawsa307