Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup NEG Metrics #2153

Merged
merged 3 commits into from
May 30, 2023
Merged

Cleanup NEG Metrics #2153

merged 3 commits into from
May 30, 2023

Conversation

swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented May 26, 2023 •
edited
Loading

  • Move metrics around to be easier to find
  • Have package separation between metrics. Mainly to reduce dependencies on the main metrics package so that can be used to publish metrics in negtypes (I will be adding metrics as part of Add GCE Request Count Metric #2150)

@swetharepakula
Remove unnecessary consts in metrics definitions
b5d3de5 
 * removal of constants makes reading the metric definition easier
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 26, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and code-elinka May 26, 2023 23:06
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@swetharepakula
Copy link
Member Author

/assign @gauravkghildiyal

/cc @sawsa307
/cc @songrx1997

@k8s-ci-robot
Copy link
Contributor

@swetharepakula: GitHub didn't allow me to request PR reviews from the following users: songrx1997, sawsa307.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @gauravkghildiyal

/cc @sawsa307
/cc @songrx1997

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sawsa307
sawsa307 reviewed May 26, 2023
View reviewed changes
pkg/neg/controller.go Outdated Show resolved Hide resolved
@swetharepakula swetharepakula mentioned this pull request May 27, 2023
Merged
gauravkghildiyal
gauravkghildiyal reviewed May 27, 2023
View reviewed changes
Copy link
Member

@gauravkghildiyal gauravkghildiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super helpful PR! Love the removal of that pile of unnecessary constants :)

pkg/neg/metrics/metricscollector/metrics_test.go Outdated Show resolved Hide resolved
pkg/neg/metrics/metricscollector/neg_metrics_collector.go Outdated Show resolved Hide resolved
pkg/neg/metrics/metricscollector/neg_metrics_collector.go Outdated Show resolved Hide resolved
@swetharepakula
Consolidate metrics by whether emitted by metrics collector
8693a51 
 * all gauge metrics that require state are moved to syncer_metrics.go
   are published by the metrics collector

 * all metrics that do not require state and not emitted by the metrics
   collector
@swetharepakula
Separate metricscollector and related metrics into package
ec8a4af 
 * metricscollector depends on negtypes therefore pull this into its own
   package

 * this separation will help when adding metrics that need to go into
   the negtypes package

 * register the metrics for each package separately to ensure isolation
   between the packages
@gauravkghildiyal
Copy link
Member

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swetharepakula
Copy link
Member Author

/retest

verification failed in downloading go dependencies for the linter and not related to the PR

@k8s-ci-robot k8s-ci-robot merged commit 2c89f80 into kubernetes:master May 30, 2023
@swetharepakula swetharepakula deleted the cleanup-neg-metrics branch May 30, 2023 22:29
k8s-ci-robot added a commit that referenced this pull request Mar 7, 2024
@k8s-ci-robot
Merge pull request #2471 from swetharepakula/backport-neg-metrics
4b948d7 
[Cherrypick #2153, #2177, #2150 into release-1.23] Add NEG count, GCERequest and GCE Latency Metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawsa307 sawsa307 sawsa307 left review comments

@gauravkghildiyal gauravkghildiyal gauravkghildiyal left review comments

@aojea aojea Awaiting requested review from aojea

@code-elinka code-elinka Awaiting requested review from code-elinka

Assignees

@gauravkghildiyal gauravkghildiyal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swetharepakula @k8s-ci-robot @gauravkghildiyal @sawsa307