update VolumeAttributesClass Deletion Protection #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
carlory
commented
Jun 11, 2024
carlory
commented
- One-line PR description: update VolumeAttributesClass Deletion Protection
- Issue link: Kubernetes VolumeAttributesClass ModifyVolume #3751
- Other comments:
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
carlory
force-pushed
the
kep-3751
branch
2 times, most recently
from
55b2c8f to
5035c28
Compare
k8s-ci-robot
added
size/M
carlory
commented
Jun 11, 2024
carlory
commented
Jun 11, 2024
|
/cc @msau42 @xing-yang |
msau42
reviewed
Jun 11, 2024
|
|
||
| There are a few conditions that will trigger add/remove pvc finalizers in the VolumeAttributesClass: | ||
| The **StorageObjectInUseProtection** admission plugin is enabled by default, but it's likely disable by users, so the **vac_finalizer_controller** is also responsible for setting the finalizer on the VolumeAttributesClass object if the finalizer is not set when the controller observes the VolumeAttributesClass object or PVC/PV object that references the VolumeAttributesClass object. |
There was a problem hiding this comment.
Do we need the admission controller if we're also going to have a controller and this is best effort?
|
@carlory please verify the PRR questions are all current - it's been a year and I believe there are one or two new questions since then. Thanks! |
|
The PRR update is in #4698 |
carlory
commented
Jun 12, 2024
| @@ -437,46 +437,38 @@ Operation metrics from [csiOperationsLatencyMetric](https://github.com/kubernete | |||
|
|
|||
| #### VolumeAttributesClass Deletion Protection | |||
|
|
|||
| While a VolumeAttributesClass is referenced by any PVC, we will prevent the object from being deleted by adding a finalizer([reference](https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/admission/storage/storageobjectinuseprotection/admission.go)). | |||
There was a problem hiding this comment.
I remove the reference to the admission controller. It will make users confused if we don't use it.
cc @msau42 updated. please review it again.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.