Use ci-built occm in all e2e tests

[mdbooth]

Previously in e2e tests we only used ci-built occm for the occm e2e test. The cinder and manila e2e tests used the latest release occm image. With this change all e2e tests deploy a ci-built occm.

What this PR does / why we need it:
This came about because we were surprised that cinder and manila e2e tests were broken by an issue in the release images.

There are pros and cons to doing this:

Pros:

• You can test changes which may affect the interaction of CPO and CSI, e.g. node labels.

Cons:

• We might accidentally merge commits which require the simultaneous upgrade of both CSI and OCCM.

Ideally we'd test both, of course. If we pick one, which is better? If we decided not to merge this, we should at least add documentation and/or comments explaining the decision for posterity.

Which issue this PR fixes(if applicable):
fixes #2220

Release note:

NONE

/cc @pierreprinetti

[k8s-ci-robot]

@mdbooth: GitHub didn't allow me to request PR reviews from the following users: pierreprinetti.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Previously in e2e tests we only used ci-built occm for the occm e2e test. The cinder and manila e2e tests used the latest release occm image. With this change all e2e tests deploy a ci-built occm.

What this PR does / why we need it:
This came about because we were surprised that cinder and manila e2e tests were broken by an issue in the release images.

There are pros and cons to doing this:

Pros:

• You can test changes which may affect the interaction of CPO and CSI, e.g. node labels.

Cons:

• We might accidentally merge commits which require the simultaneous upgrade of both CSI and OCCM.

Ideally we'd test both, of course. If we pick one, which is better? If we decided not to merge this, we should at least add documentation and/or comments explaining the decision for posterity.

Which issue this PR fixes(if applicable):
fixes #2220

Release note:

NONE

/cc @pierreprinetti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jichenjc]

I am in favor of this PR but I am open for folks with different opinion or know the history..

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierreprinetti]

Sounds reasonable, thanks @mdbooth!
Deferring to the owners for a LGTM.

[mdbooth]

Just a reminder that the manila e2e tests are permafailing and should be ignored: https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/openstack-cloud-csi-manila-e2e-test

[mdbooth]

@zetaab Do you have an opinion on this?

[dulek]

My experiences with OpenStack development are that this is a correct approach. Leaving LGTM to @zetaab.

[zetaab]

/lgtm

[zetaab]

/override openstack-cloud-csi-manila-e2e-test

[k8s-ci-robot]

@zetaab: Overrode contexts on behalf of zetaab: openstack-cloud-csi-manila-e2e-test

In response to this:

/override openstack-cloud-csi-manila-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zetaab]

/cherry-pick release-1.27

[k8s-infra-cherrypick-robot]

@zetaab: new pull request created: #2352

In response to this:

/cherry-pick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zetaab]

/cherry-pick release-1.26

[k8s-infra-cherrypick-robot]

@zetaab: new pull request created: #2353

In response to this:

/cherry-pick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.