Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cinder e2e tests permafailing? #2220

Closed
pierreprinetti opened this issue Apr 27, 2023 · 5 comments · Fixed by #2227
Closed

cinder e2e tests permafailing? #2220

pierreprinetti opened this issue Apr 27, 2023 · 5 comments · Fixed by #2227

Comments

@pierreprinetti
Copy link
Member

TL;DR: e2e tests in this PR systematically fail.

While investigating with the help of @mdbooth, we found that the occm release manifests are still referring to v1.27.0. That version is broken IIUC, and that looks like a good root cause candidate.

One other thing that surprised me is that we apparently run release images as a base for presubmits in this job. Is that intentional? Shall we be running a CI build in the e2e CSI presubmit jobs?

CC @zetaab @mdbooth

@mdbooth
Copy link
Contributor

mdbooth commented Apr 27, 2023

So we definitely need to update the manifests to point to v1.27.1.

However, in terms of CI I personally think we should be running the code under test for all components in all jobs. So even though this is the csi-cinder job, I still think that occm should be running the code from the PR under test.

@zetaab If you agree with that either me or @pierreprinetti can knock up a PR to do that pretty quickly. What do you think?

@mdbooth
Copy link
Contributor

mdbooth commented Apr 27, 2023

I think #2221 should work round this, but as above I think the real problem is that we're running a release image at all.

@jichenjc
Copy link
Contributor

#2221 merged, do we still need this to track or we can close this issue now?

@mdbooth
Copy link
Contributor

mdbooth commented Apr 28, 2023

@jichenjc Although #2221 worked round the problem, I am proposing that we fix the csi-cinder test to use an image built from the PR under test for all CPO components, not just CSI. It would be a very simple change. The only reason I haven't already submitted it already is that somebody deliberately created the current solution and I don't understand why.

@jichenjc
Copy link
Contributor

jichenjc commented May 2, 2023

The only reason I haven't already submitted it already is that somebody deliberately created the current solution and I don't understand why.

I don't think someone deliberately do this ,if you have any thing to propose, please submit PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants