Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster-autoscaler-release-1.28] backport Azure e2e tests #7245

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #7204

/assign nojnhuh

NONE

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign jackfrancis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 5, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 5, 2024

/test ?

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: The following commands are available to trigger optional jobs:

  • /test pull-cluster-autoscaler-e2e-azure
  • /test pull-cluster-autoscaler-e2e-azure-1-28
  • /test pull-kubernetes-e2e-autoscaling-vpa-full

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-autoscaler-e2e-azure
  • pull-cluster-autoscaler-e2e-azure-1-28

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 5, 2024

/test pull-cluster-autoscaler-e2e-azure-1-28

@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 5, 2024

/test pull-cluster-autoscaler-e2e-azure

@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-autoscaler-e2e-azure-1-28 ae32087 link false /test pull-cluster-autoscaler-e2e-azure-1-28

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 6, 2024

@Bryce-Soghigian Could you please push this fix to this branch (assuming you have permission) to see if that fixes the test? It looks like the default VMSS type changed between 1.28 and 1.29.

diff --git a/cluster-autoscaler/cloudprovider/azure/test/e2e/e2e_suite_test.go b/cluster-autoscaler/cloudprovider/azure/test/e2e/e2e_suite_test.go
index a0d4a3a49..2505d23ec 100644
--- a/cluster-autoscaler/cloudprovider/azure/test/e2e/e2e_suite_test.go
+++ b/cluster-autoscaler/cloudprovider/azure/test/e2e/e2e_suite_test.go
@@ -102,6 +102,7 @@ var _ = BeforeSuite(func() {
                                },
                        },
                },
+               "azureVMType": "vmss",
                "autoDiscovery": map[string]interface{}{
                        "clusterName": clusterName,
                },

If you don't have permission to push here I can close this PR and open a fresh one that includes this change.

@Bryce-Soghigian
Copy link
Member

yeah let me give that a shot

@Bryce-Soghigian
Copy link
Member

No dice, you want to open another PR?

@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 6, 2024

Yep I'll do that. Thanks for trying!

/close

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Closed this PR.

In response to this:

Yep I'll do that. Thanks for trying!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 6, 2024

Manual cherry-pick open: #7251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants