-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster-autoscaler-release-1.28] backport Azure e2e tests #7245
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@nojnhuh: The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-autoscaler-e2e-azure-1-28 |
/test pull-cluster-autoscaler-e2e-azure |
@k8s-infra-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@Bryce-Soghigian Could you please push this fix to this branch (assuming you have permission) to see if that fixes the test? It looks like the default VMSS type changed between 1.28 and 1.29. diff --git a/cluster-autoscaler/cloudprovider/azure/test/e2e/e2e_suite_test.go b/cluster-autoscaler/cloudprovider/azure/test/e2e/e2e_suite_test.go
index a0d4a3a49..2505d23ec 100644
--- a/cluster-autoscaler/cloudprovider/azure/test/e2e/e2e_suite_test.go
+++ b/cluster-autoscaler/cloudprovider/azure/test/e2e/e2e_suite_test.go
@@ -102,6 +102,7 @@ var _ = BeforeSuite(func() {
},
},
},
+ "azureVMType": "vmss",
"autoDiscovery": map[string]interface{}{
"clusterName": clusterName,
}, If you don't have permission to push here I can close this PR and open a fresh one that includes this change. |
yeah let me give that a shot |
No dice, you want to open another PR? |
Yep I'll do that. Thanks for trying! /close |
@nojnhuh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Manual cherry-pick open: #7251 |
This is an automated cherry-pick of #7204
/assign nojnhuh