-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster-autoscaler-release-1.30] backport Azure e2e tests #7204
[cluster-autoscaler-release-1.30] backport Azure e2e tests #7204
Conversation
/hold testing this will require some test-infra changes |
kubernetes/test-infra#33361 will enable the job to run (correctly) here. Let's merge that before this one so we can iterate here if needed. |
/test ? |
@nojnhuh: The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-autoscaler-e2e-azure-1-30 |
e2e job passed. @tallaxes Do you know the recommended way to fix the dependency error the unit test job is throwing? Based on this it looks like the release branches of cluster-autoscaler may not be fully module-aware: git diff upstream/cluster-autoscaler-release-1.30 upstream/master -- hack/for-go-proj.sh diff --git a/hack/for-go-proj.sh b/hack/for-go-proj.sh
index ec55ef23d..f44f997c4 100755
--- a/hack/for-go-proj.sh
+++ b/hack/for-go-proj.sh
@@ -19,7 +19,7 @@ set -o pipefail
set -o nounset
CONTRIB_ROOT="$(dirname ${BASH_SOURCE})/.."
-PROJECT_NAMES=(addon-resizer cluster-autoscaler vertical-pod-autoscaler)
+PROJECT_NAMES=(addon-resizer vertical-pod-autoscaler)
if [[ $# -ne 1 ]]; then
echo "missing subcommand: [build|install|test]"
@@ -43,12 +43,7 @@ esac
for project_name in ${PROJECT_NAMES[*]}; do
(
- if [[ $project_name == cluster-autoscaler ]];then
- export GO111MODULE=off
- else
- export GO111MODULE=auto
- fi
-
+ export GO111MODULE=auto
project=${CONTRIB_ROOT}/${project_name}
echo "${CMD}ing ${project}"
cd "${project}"
@@ -68,6 +63,10 @@ for project_name in ${PROJECT_NAMES[*]}; do
done;
if [ "${CMD}" = "build" ] || [ "${CMD}" == "test" ]; then
- cd ${CONTRIB_ROOT}/vertical-pod-autoscaler/e2e
+ pushd ${CONTRIB_ROOT}/vertical-pod-autoscaler/e2e
go test -mod vendor -run=None ./...
+ popd
+ pushd ${CONTRIB_ROOT}/cluster-autoscaler/
+ go test ./...
+ popd
fi |
/hold for squash |
2e88b23
to
08108e3
Compare
CI checks are passing now and I cleaned up the history here. /hold cancel |
/cherry-pick cluster-autoscaler-release-1.29 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.29 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bryce-Soghigian, nojnhuh, rakechill, tallaxes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
45886e3
into
kubernetes:cluster-autoscaler-release-1.30
@nojnhuh: new pull request created: #7245 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@nojnhuh: new pull request created: #7246 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@nojnhuh: new pull request created: #7247 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR backports the Azure e2e tests added by #6969 and related PRs to the master branch.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: