Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster-autoscaler-release-1.30] backport Azure e2e tests #7204

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 23, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR backports the Azure e2e tests added by #6969 and related PRs to the master branch.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 23, 2024
@k8s-ci-robot k8s-ci-robot requested a review from nilo19 August 23, 2024 18:43
@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Aug 23, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 23, 2024

/hold testing this will require some test-infra changes

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 23, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 23, 2024

kubernetes/test-infra#33361 will enable the job to run (correctly) here. Let's merge that before this one so we can iterate here if needed.

@nojnhuh nojnhuh changed the title backport Azure e2e tests [cluster-autoscaler-release-1.30] backport Azure e2e tests Aug 23, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 23, 2024

/test ?

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: The following commands are available to trigger optional jobs:

  • /test pull-cluster-autoscaler-e2e-azure-1-30
  • /test pull-kubernetes-e2e-autoscaling-vpa-full

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-autoscaler-e2e-azure-1-30

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 23, 2024

/test pull-cluster-autoscaler-e2e-azure-1-30

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 23, 2024

e2e job passed.
/hold cancel

@tallaxes Do you know the recommended way to fix the dependency error the unit test job is throwing? Based on this it looks like the release branches of cluster-autoscaler may not be fully module-aware:

git diff upstream/cluster-autoscaler-release-1.30 upstream/master -- hack/for-go-proj.sh
diff --git a/hack/for-go-proj.sh b/hack/for-go-proj.sh
index ec55ef23d..f44f997c4 100755
--- a/hack/for-go-proj.sh
+++ b/hack/for-go-proj.sh
@@ -19,7 +19,7 @@ set -o pipefail
 set -o nounset

 CONTRIB_ROOT="$(dirname ${BASH_SOURCE})/.."
-PROJECT_NAMES=(addon-resizer cluster-autoscaler vertical-pod-autoscaler)
+PROJECT_NAMES=(addon-resizer vertical-pod-autoscaler)

 if [[ $# -ne 1 ]]; then
   echo "missing subcommand: [build|install|test]"
@@ -43,12 +43,7 @@ esac

 for project_name in ${PROJECT_NAMES[*]}; do
   (
-    if [[ $project_name == cluster-autoscaler ]];then
-      export GO111MODULE=off
-    else
-      export GO111MODULE=auto
-    fi
-
+    export GO111MODULE=auto
     project=${CONTRIB_ROOT}/${project_name}
     echo "${CMD}ing ${project}"
     cd "${project}"
@@ -68,6 +63,10 @@ for project_name in ${PROJECT_NAMES[*]}; do
 done;

 if [ "${CMD}" = "build" ] || [ "${CMD}" == "test" ]; then
-  cd ${CONTRIB_ROOT}/vertical-pod-autoscaler/e2e
+  pushd ${CONTRIB_ROOT}/vertical-pod-autoscaler/e2e
   go test -mod vendor -run=None ./...
+  popd
+  pushd ${CONTRIB_ROOT}/cluster-autoscaler/
+  go test ./...
+  popd
 fi

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 23, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 27, 2024

/hold for squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 27, 2024

CI checks are passing now and I cleaned up the history here.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 27, 2024

/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

@k8s-infra-cherrypick-robot

@nojnhuh: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.29 in a new PR and assign it to you.

In response to this:

/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-autoscaler-e2e-azure 08108e3 link false /test pull-cluster-autoscaler-e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bryce-Soghigian, nojnhuh, rakechill, tallaxes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 45886e3 into kubernetes:cluster-autoscaler-release-1.30 Sep 5, 2024
7 of 8 checks passed
@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #7245

In response to this:

/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #7246

In response to this:

/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #7247

In response to this:

/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants