Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deployment parameters robust for various acs-engine versions #682

Merged
merged 2 commits into from
Feb 26, 2018
Merged

Make deployment parameters robust for various acs-engine versions #682

merged 2 commits into from
Feb 26, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Feb 24, 2018 •
edited
Loading

This PR makes deployment parameters robust for various acs-engine versions by

  • reading deployment parameters from acs-engine generated azuredeploy.parameters.json file
  • simplifier deployment secrets

/kind bug

Fixes #644 and #642

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2018
@feiskyer
Copy link
Member Author

/assign @mwielgus @MaciekPytel

This should be targeted for v1.10.

@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@mwielgus mwielgus merged commit b81f70c into kubernetes:master Feb 26, 2018
@feiskyer feiskyer deleted the azure-standard branch February 27, 2018 01:28
@feiskyer
Copy link
Member Author

@mwielgus Thanks

@feiskyer feiskyer mentioned this pull request Mar 2, 2018
Closed
@feiskyer feiskyer restored the azure-standard branch March 29, 2018 03:13
yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this pull request Feb 22, 2024
@k8s-ci-robot
Merge pull request kubernetes#682 from tenzen-y/fix-typos
6384f2f 
Fix typos for the MPIJob
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MaciekPytel MaciekPytel

@mwielgus mwielgus

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feiskyer @mwielgus @MaciekPytel @k8s-ci-robot