Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for extension parameters on Azure #642

Closed
gmagniez opened this issue Feb 9, 2018 · 6 comments
Closed

Support for extension parameters on Azure #642

gmagniez opened this issue Feb 9, 2018 · 6 comments
Assignees
Labels
area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider

Comments

@gmagniez
Copy link

gmagniez commented Feb 9, 2018

We use a custom extension (to be precise, a preprovision extension) which needs a parameter, but when trying to scale we face the following error:

E0209 14:20:37.252154       1 static_autoscaler.go:298] Failed to scale up: failed to increase node group size: resources.DeploymentsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidDeploymentParameterValue" Message="The value of deployment parameter 'register-dnsParameters' is null. Please specify the value or use the parameter reference. See https://aka.ms/arm-deploy/#parameter-file for details."

It seems that the generated ARM deployment is missing the parameter 'register-dnsParameters' which is defined in our acs-engine cluster definition:

"extensionProfiles": [
      {
          "name": "register-dns",
          "rootURL": "https://raw.githubusercontent.com/tesharp/acs-engine/register-dns-extension/",
          "version": "v1",
          "script": "register-dns.sh",
          "extensionParameters": "my.domain.name.com"
      }
    ],
@feiskyer
Copy link
Member

@gmagniez Does the extension use securestring parameters? Have you tried ace-engine scale command?

@aleksandra-malinowska aleksandra-malinowska added area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider labels Feb 12, 2018
@gmagniez
Copy link
Author

gmagniez commented Feb 12, 2018

Hello,
I don't think that the extension is using securestrings, It is juste declared like that:

"preProvisionExtension":
        {
          "name": "register-dns",
          "singleOrAll": "All"
        }
...
"extensionProfiles": [
      {
          "name": "register-dns",
          "rootURL": "https://raw.githubusercontent.com/tesharp/acs-engine/register-dns-extension/",
          "version": "v1",
          "script": "register-dns.sh",
          "extensionParameters": "my.domain.name.com"
      }
    ],

Scaling with acs-engine scale works perfectly.

@feiskyer
Copy link
Member

@gmagniez Thanks, I will check how to make this work.

@feiskyer
Copy link
Member

/assign

@feiskyer
Copy link
Member

feiskyer commented Mar 2, 2018

Fixed in #682

@feiskyer
Copy link
Member

feiskyer commented Mar 2, 2018

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider
Projects
None yet
Development

No branches or pull requests

4 participants