Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Burst and QPS client params to capi k8s clients 1.26 #6468

Conversation

kdw174
Copy link
Contributor

@kdw174 kdw174 commented Jan 24, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Pulls in kube-client-burst and kube-client-qps flags
  • Passes the kubeClientBurst and kubeClientQPS flags to the clusterapi provider k8s clients to allow tuning of client and avoid excessive client-side throttling.

Which issue(s) this PR fixes:

Fixes #6333

Does this PR introduce a user-facing change?

- add `--kube-client-burst` and `--kube-client-qps` to control how many requests CA can do against kubernetes
- kubeClientBurst and kubeClientQPS flags are now passed to the clusterapi provider k8s clients

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Cherry pick of #6416 and #5223

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kdw174
Once this PR has been reviewed and has the lgtm label, please assign x13n for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kdw174
Copy link
Contributor Author

kdw174 commented Feb 12, 2024

@enxebre or @feiskyer bump on a review for this. Let me know if there's anything else you need. Thanks

@mwielgus
Copy link
Contributor

What about other CA versions? Should we expect cherrypick also to their branches?

@kdw174
Copy link
Contributor Author

kdw174 commented Mar 25, 2024

What about other CA versions? Should we expect cherrypick also to their branches?

@mwielgus I've already had PR's merged for 1.27-1.29. Those are linked to the issue

@x13n
Copy link
Member

x13n commented May 7, 2024

1.26 is past the support window. Even k8s 1.27 end of life is 2024-06-28, so it will get its last CA patch release in May (see schedule).

/close

@k8s-ci-robot
Copy link
Contributor

@x13n: Closed this PR.

In response to this:

1.26 is past the support window. Even k8s 1.27 end of life is 2024-06-28, so it will get its last CA patch release in May (see schedule).

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants