-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster-autoscaler: allow setting kuberentes client burst and qps to avoid rate limiting #5223
Conversation
With this change as-is, the rate limiting will actually be 2x than whatever is configured via flags (assuming there's a lot of load on both events and non-events and rate limiting is the bottleneck). Maybe it would be cleaner to use separate flags for events client? |
ideally we'd use a single client, since atm it already uses 2x the configured rate, if we hardcode the "there are 2 different clients" into the cli that could be an issue later too idk if the event or the regular client produces our throttling issues |
ah the throttling is from |
Sorry, I just noticed I missed this one. Assigning so I won't miss it again: /assign I think setting the rate limits on a single (non-event) client makes sense. The clients were split on purpose so I think merging them back might be problematic. Perhaps nowadays with API priority and fairness it is doable, but I'd need to better understand the implications first. I'll look into this. Meanwhile, let's apply the limits to just one client. |
f2bbc09
to
178e124
Compare
updated it as requested |
178e124
to
cd26bcf
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grosser, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cluster-autoscaler: allow setting kuberentes client burst and qps to avoid rate limiting
cluster-autoscaler: allow setting kuberentes client burst and qps to avoid rate limiting
cluster-autoscaler: allow setting kuberentes client burst and qps to avoid rate limiting
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
Does this PR introduce a user-facing change?