Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: update cluster-autoscaler to 1.28 #6340

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Helm: update cluster-autoscaler to 1.28 #6340

merged 1 commit into from
Dec 6, 2023

Conversation

ilpianista
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Bump cluster-autoscaler version.

Which issue(s) this PR fixes:

Actually, my autoscaler is stuck with:

static_autoscaler.go:354] Failed to get node infos for groups: ASG "eksctl-xyz" uses the unknown EC2 instance type "m7i.2xlarge"

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update CA Chart's `appVersion` and `image.tag` value from 1.27.2 to 1.28.1

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 4, 2023
Copy link

linux-foundation-easycla bot commented Dec 4, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ilpianista / name: Andrea Scarpino (a70364d)

@k8s-ci-robot
Copy link
Contributor

Welcome @ilpianista!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2023
@ilpianista ilpianista changed the title Update cluster-autoscaler to 1.28 Helm: update cluster-autoscaler to 1.28 Dec 4, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 4, 2023
@gjtempleton
Copy link
Member

/hold
Going to stick a hold on this until the 1.28.2 release has been cut (this week) and say that we jump straight to that as there was a bug in leader election introduced with 1.28.1.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2023
@gjtempleton
Copy link
Member

/unhold

The 1.28.2 release has been cut and published now, can you update the default image to point to that version please?

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@ilpianista
Copy link
Contributor Author

@gjtempleton done!

@gjtempleton
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, ilpianista

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8f75e9c into kubernetes:master Dec 6, 2023
6 checks passed
@ilpianista ilpianista deleted the patch-1 branch December 6, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants