Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Autoscaler patch releases Nov 2023 #6293

Closed
x13n opened this issue Nov 16, 2023 · 15 comments · Fixed by kubernetes/k8s.io#6116
Closed

Cluster Autoscaler patch releases Nov 2023 #6293

x13n opened this issue Nov 16, 2023 · 15 comments · Fixed by kubernetes/k8s.io#6116
Labels
area/cluster-autoscaler kind/feature Categorizes issue or PR as related to a new feature.

Comments

@x13n
Copy link
Member

x13n commented Nov 16, 2023

I'm planning to cut new Cluster Autoscaler patch releases for 1.26-28 next week. If there are any bugfix cherry-picks you want included, please prepare the PRs and let me know in the comments.

Tagging cloud provider owners for visibility:
@4ND3R50N
@7fELF
@alphajc
@andrewsykim
@Andrius521
@apricote
@ArturasRa
@arunmk
@avorima
@BigDarkClown
@cprivitere
@ctrox
@davidjumani
@dbonfigli
@deitch
@detiber
@displague
@d-mo
@dougsong
@drmorr0
@ellistarn
@elmiko
@enxebre
@ericrrath
@feiskyer
@gajicdev
@gandhipr
@gjtempleton
@happytreees
@hardikdr
@hello2mao
@jackfrancis
@jayantjain93
@jaypipes
@Jeffwan
@jlamillan
@johnl
@jtherin
@kevin-wangzefeng
@LKaemmerling
@louisportay
@MaciekPytel
@marwanad
@MorrisLaw
@mrajashree
@NeilW
@nilo19
@optik-aper
@OriHoch
@pawelkuc

@x13n x13n added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 16, 2023
@x13n
Copy link
Member Author

x13n commented Nov 16, 2023

@jackfrancis
Copy link
Contributor

@x13n thank you for this, my merged PRs are fine to skip and wait to be included in next minor release

@RainbowMango
Copy link
Member

LGTM thank you for the notice

@ricardov1
Copy link
Contributor

@x13n these have been merged but just want to make sure they're included in the releases:
1.26: #6287
1.27: #6285
1.28: #6283

@ctrox
Copy link
Contributor

ctrox commented Nov 20, 2023

@x13n thanks!

#6303
#6304
#6305

@x13n
Copy link
Member Author

x13n commented Nov 21, 2023

@ricardov1 @ctrox Thanks, all the PRs you listed will be included.

@ClareCat
Copy link

Any chance a patch release can be cut for 1.25 too?

@x13n
Copy link
Member Author

x13n commented Nov 22, 2023

Unfortunately, 1.25 reached end of life a month ago, I'm only patching the k/k versions that are still supported: https://kubernetes.io/releases/

@ricardov1
Copy link
Contributor

hey @x13n, there was a bug introduced by this PR (#6072) that causes the cluster autoscaler pod to crash when using the leader-elect flag. This PR (#6115) fixes it but it wasn't included in the patch. is it posible to create an adhoc patch with this bug fix? and if so, what would that timeline look like?

@x13n
Copy link
Member Author

x13n commented Nov 30, 2023

Ah, good catch. I think this justifies a new set of patches. Can you cherrypick the changes to affected release branches?

@allenmun197
Copy link
Contributor

@x13n

here are the backport PRs of #6115 to 1.26/1.27/1.28 release branches

1.26 - #6332
1.27 - #6331
1.28 - #6330

@x13n
Copy link
Member Author

x13n commented Dec 1, 2023

Thanks! Approved all 3, will cut new images next week.

@vishalanarase
Copy link
Member

vishalanarase commented Dec 2, 2023

@x13n is it possible to include?

1.28.2 - #6322
1.28.2 - #6324

@x13n
Copy link
Member Author

x13n commented Dec 5, 2023

I'd like to limit the changes just to fix the bug introduced with the November patches. For all other changes we'll follow the regular schedule. Please prepare cherrypick PRs to make sure the changes are included in the next patch release.

@x13n
Copy link
Member Author

x13n commented Dec 5, 2023

A new set of patches has been released, fixing the --leader-elect flag problem. Thanks @ricardov1 for raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants