-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add elect-leader flag to the pflag #6115
Conversation
Welcome @aagusuab! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aagusuab, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Backport of #6115 fix: add elect-leader flag to the pflag into 1.26
Backport of #6115 fix: add elect-leader flag to the pflag into 1.27
Backport of #6115 fix: add elect-leader flag to the pflag into 1.28
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, setting up the autoscaler pod with --elect-leader flags causes
unknown flag: elect-leader error.
The current main function leaves out the elect leader flag from the flag initialization.
This PR will fix that.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: