Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure virtual machine availability sets (VMAS) #514

Merged
merged 9 commits into from
Dec 29, 2017

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Dec 28, 2017

Continue of #449.

This PR adds initial support for Azure virtual machine availability sets (VMAS). Significant changes include

  • Add vmType parameters to indicate different virtual machine types. Candidate values are 'vmss' and 'standard'
  • Add agent pools implementation (standard vmType) of NodeGroup
  • Add more options for scaling agent pools
  • Add more fake clients and unit tests

Special notes for reviewers:

  • Only one node group supported yet
  • Some functions (in azure_util.go) are copied from acs-engine. They are not ventured because of various vendor problems, e.g. i18n and go template. acs-engine should be adjusted before vendoring those functions
  • Azure API calls may hit requests count limits which need to be addressed in further PRs

/cc @brendandburns @andyzhangx @jdumars

/assign @mwielgus @MaciekPytel

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 28, 2017
@feiskyer
Copy link
Member Author

Update: Verified one node group scaling properly in following scenarios

  • Cluster deployed via acs-engine without windows containers (standard vmType)
  • Cluster deployed via acs-engine with windows containers (standard vmType)
  • Cluster manually deployed on Azure VMSS (vmss vmType)

Also /cc @wbuchwalter (author of Kubernetes-acs-engine-autoscaler). Could you also take a look at this?

@mwielgus
Copy link
Contributor

Is the Azure library also updated in the core Kuberentes?

@mwielgus
Copy link
Contributor

Please fix the conflicts.

@feiskyer
Copy link
Member Author

Is the Azure library also updated in the core Kuberentes?

@mwielgus Azure library version not updated in this PR, only adding a new sub-package.

@feiskyer
Copy link
Member Author

Please fix the conflicts.

Rebased and conflicts resolved.

@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2017
@mwielgus mwielgus merged commit c24580a into kubernetes:master Dec 29, 2017
@feiskyer feiskyer deleted the node-pools branch December 30, 2017 00:16
@feiskyer
Copy link
Member Author

@mwielgus thanks

yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this pull request Feb 22, 2024
Preemption within ClusterQueue and cohort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants