Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Make kubernetes utils reusable for external packages #1975

Closed
feiskyer opened this issue Jan 2, 2018 · 0 comments · Fixed by #2010
Closed

Make kubernetes utils reusable for external packages #1975

feiskyer opened this issue Jan 2, 2018 · 0 comments · Fixed by #2010

Comments

@feiskyer
Copy link
Member

feiskyer commented Jan 2, 2018 •
edited
Loading

Is this a request for help?:

Request.

Is this an ISSUE or FEATURE REQUEST? (choose one):

FEATURE REQUEST.

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)

Kubernetes

What happened:

kubernetes/autoscaler#514 adds agent pools support to kubernetes cluster-autoscaler, but it copies some functions from acs-engine instead of vendoring because of various vendor problems, e.g. i18n and go template. This includes

  • Transformer.NormalizeForK8sVMASScalingUp
  • armhelpers.GetVMNameIndex

What you expected to happen:

We should make those functions reusable (e.g. via external vendors) by removing direct dependency of i18n and go templates.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract common utils to separate packages feiskyer/acs-engine
1 participant
@feiskyer