Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud provider for Rancher with RKE2 #4975

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

ctrox
Copy link
Contributor

@ctrox ctrox commented Jun 15, 2022

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds cluster-autoscaler provider for Rancher with RKE2. This has been tried before but as this was for RKE (1) clusters, it works in a completely different way as Rancher fully changed their APIs and provisioning for RKE2. This provider only supports RKE2, which is now GA as of Rancher v2.6.5.

Special notes for your reviewer:

RKE2 provisioning uses cluster-api under the hood, so there are some similarities to the cluster-api provider but not enough to be able to share code. Plus I assume that is probably not really desired anyway. Since the Rancher server manages the cluster-api objects, it's not possible to simply run the cluster-api autoscaler as these two controllers would fight over control, plus changes would not be reflected in the corresponding Rancher API objects.

Not super sure about the proper process of the OWNERS file, but I saw in a recent PR that added a cloud provider that it was requested that there's a OWNERS file with the gitub handles commented out, so I added that. All the owners I added are members of @ninech and we are committed to maintaining this but of course would be more than happy if anybody else wants to help maintain this (e.g Rancher themselves or Ubisoft which was working on the old PR).

Does this PR introduce a user-facing change?

yes

Adds support for Rancher with RKE2 in cluster-autoscaler

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @ctrox!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 15, 2022
@ctrox ctrox force-pushed the provider-rke branch 2 times, most recently from 58d1d8c to b2b0fd6 Compare June 15, 2022 13:09
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2022
@ctrox
Copy link
Contributor Author

ctrox commented Jul 6, 2022

/assign @towca

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2022
@mwielgus
Copy link
Contributor

Please rebase and we are good to go.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2022
@ctrox
Copy link
Contributor Author

ctrox commented Aug 10, 2022

Please rebase and we are good to go.

Done, thank you!

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ctrox, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1dc25c6 into kubernetes:master Aug 10, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
Add cloud provider for Rancher with RKE2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants