Add Rancher as a cloud provider #4041

douglasmakey · 2021-04-27T18:30:17Z

Hello Kubernetes Community,

We are the Ubisoft Kubernetes Team: @douglasmakey, @patrickdappollonio, and @promagne. We worked during the past couple of months alongside Rancher (and now Suse) to implement a Node Autoscaler based on the Rancher software as a cloud provider, and we're sending it here for broader community use.

It has the basic support you would expect, like increasing and decreasing node groups and configuring using a ConfigMap.

We're here if you have any questions!

k8s-ci-robot · 2021-04-27T18:30:20Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-04-27T18:30:24Z

Welcome @douglasmakey!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

mwielgus

Please update the main readme as well so.

douglasmakey · 2021-05-25T16:50:54Z

Please update the main readme as well so.

Done, thanks @mwielgus

reylejano · 2021-05-26T14:37:09Z

/assign @aleksandra-malinowska @feiskyer

feiskyer

Could you also add an OWNERS file in the new rancher directory?

k8s-ci-robot · 2021-05-27T05:40:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglasmakey, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cluster-autoscaler/OWNERS~~ [feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

douglasmakey · 2021-05-27T21:14:08Z

Could you also add an OWNERS file in the new rancher directory?

Done, thanks @feiskyer

douglasmakey · 2021-10-01T14:57:58Z

@douglasmakey can you please remove the OWNERS file from this PR?

Hi @leodotcloud, sure, I will remove the file.

Jeffwan · 2021-10-01T18:36:29Z

cluster-autoscaler/cloudprovider/rancher/examples/autoscaler-config-example.yaml

+    access=token-abcdef
+    secret=ksjdhfiusdhfkjsdfhisudhfnskjdfhskjdfhksdjfhksjdfhksdjf
+    cluster-id=c-abcdef
+  autoscaler_node_arg: "2:6:c-abcdef:np-abcde"


minor: new line

Jeffwan · 2021-10-01T18:37:07Z

cluster-autoscaler/cloudprovider/rancher/examples/autoscaler-noconfig-template.txt

@@ -0,0 +1,118 @@
+apiVersion: rbac.authorization.k8s.io/v1


seems it ends with txt. is it used for rendering templates?

Jeffwan · 2021-10-01T18:38:35Z

cluster-autoscaler/cloudprovider/rancher/rancher_cloud_provider.go

+
+// GetAvailableGPUTypes return all available GPU types cloud provider supports.
+func (u rancherProvider) GetAvailableGPUTypes() map[string]struct{} {
+	return availableGPUTypes


is this supported in rancher platform? Seems it's an empty map?

Jeffwan · 2021-10-01T18:40:13Z

cluster-autoscaler/cloudprovider/rancher/README.md

+
+```
+docker push rancher/cluster-autoscaler:dev
+```


Can you add some information about contacts of maintainers here?

It would be helpful for maintainers to reach out to the cloud provider owners for release coordination when necessary.

Jeffwan · 2021-10-01T18:41:11Z

@leodotcloud I help review non-rancher codes and please take a look.

k8s-ci-robot · 2021-10-25T16:39:20Z

@douglasmakey: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xrl · 2021-11-19T06:07:07Z

How is this going? We'd love to use it with our rancher infrastructure.

reylejano · 2021-11-19T15:17:17Z

@douglasmakey please rebase

xrl · 2021-11-19T16:43:27Z

I am having some issues setting up this code on a new rancher-controlled cluster. I bet my token is wrong but this stacktrace is pretty nasty: https://gist.github.com/xrl/e7caf2e45048aa71b0d489267741c251

~~Holler if you want more of it, it's dumping all the goroutine stacks.~~ I just went ahead and put in the full log before I try and fix things.

k8s-triage-robot · 2022-02-17T17:18:56Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

patrickdappollonio · 2022-02-17T17:24:06Z

Hey all!

Just for transparency purposes, both @douglasmakey and myself -- the two people running this PR -- have left Ubisoft since and moved on to new adventures. Back then, I think we were lacking some of the support from Rancher to have this merged.

As such, we might be able to contribute some extra time but it would be better if Ubisoft/Rancher takes ownership instead... Speaking for both Douglas and myself, happy if either wants to take over the PR to have it merged.

Hope that helps with expectations regarding whether this will be merged or not!

leodotcloud · 2022-02-17T18:22:08Z

@patrickdappollonio Thank you for the note, I am in a similar situation too.

Bringing this to your attention @cjellick, @deniseschannon, @jambajaar, @cloudnautique.

leodotcloud · 2022-02-17T18:22:27Z

/remove-lifecycle stale

mwielgus · 2022-05-17T13:02:04Z

Closed due to inactivity. Feel free to reopen.

glermaidt · 2022-06-03T14:45:54Z

Please re-open. We really need this.

patrickdappollonio · 2022-06-03T14:52:57Z

Unfortunately, unless someone wants to take it from here, neither @douglasmakey nor I still work at the previous company where this was our goal.

cambierr · 2022-06-03T16:10:42Z

For what it's worth we (I mean my company but doing it in an OSS fashion) are building the equivalent of this using the "external grpc" cloud provider. It should reach 1.0 by end of the month Sent from a typical smartphone. If this is illiterate, it’s the voice recognition’s fault.

…

________________________________ From: patrickdappollonio ***@***.***> Sent: Friday, June 3, 2022 4:53:09 PM To: kubernetes/autoscaler ***@***.***> Cc: Romain Cambier ***@***.***>; Mention ***@***.***> Subject: Re: [kubernetes/autoscaler] Add Rancher as a cloud provider (#4041) Unfortunately, unless someone wants to take it from here, neither @douglasmakey<https://github.com/douglasmakey> nor I still work at the previous company where this was our goal. — Reply to this email directly, view it on GitHub<#4041 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACTBVY2E2NJCJAMH24QQ7PDVNIL5LANCNFSM43VQ3K3Q>. You are receiving this because you were mentioned.Message ID: ***@***.***>

glermaidt · 2022-06-04T23:05:40Z

@cambierr - This sounds fantastic! - Could you provide mere deets? And you said OSS. Am I to presume it will be open-sourced?

cambierr · 2022-06-05T09:52:45Z

Yep, as soon as it will be considered stable, we'll make make it public. Sent from a typical smartphone. If this is illiterate, it’s the voice recognition’s fault.

…

________________________________ From: George Lerma ***@***.***> Sent: Sunday, June 5, 2022 1:05:53 AM To: kubernetes/autoscaler ***@***.***> Cc: Romain Cambier ***@***.***>; Mention ***@***.***> Subject: Re: [kubernetes/autoscaler] Add Rancher as a cloud provider (#4041) @cambierr<https://github.com/cambierr> - This sounds fantastic! - Could you provide mere deets? And you said OSS. Am I to presume it will be open-sourced? — Reply to this email directly, view it on GitHub<#4041 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACTBVY6LXCNUJAODBW4DQQ3VNPONDANCNFSM43VQ3K3Q>. You are receiving this because you were mentioned.Message ID: ***@***.***>

rodcloutier · 2022-06-14T20:04:17Z

We, at Ubisoft, will work with Rancher to re-open this MR.

ctrox · 2022-06-15T14:27:57Z

An bit of a coincidence @rodcloutier, you wrote this just a few hours before we got ready to post our RKE2 autoscaler implementation (see PR linked above). This PR here contains an implementation for RKE1, RKE2 provisioning in Rancher was not even a thing back then. Were you planning on adding support for RKE1 or RKE2?

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 27, 2021

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 27, 2021

k8s-ci-robot requested review from Jeffwan and towca April 27, 2021 18:30

feat(cloudprovider): Implement rancher as a cloud provider.

a97eeee

douglasmakey force-pushed the master branch from d30a5e3 to a97eeee Compare April 27, 2021 18:39

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 27, 2021

mwielgus suggested changes May 3, 2021

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2021

jbartosik added the area/cluster-autoscaler label May 5, 2021

Negashev mentioned this pull request May 5, 2021

[Feature] Rancher 2.0 & Cluster Autoscaling rancher/rancher#15145

Open

sync upstream.

f3d2cb3

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2021

feat(cloudprovider.rancher): update readme.

962f302

douglasmakey requested a review from mwielgus May 26, 2021 14:33

k8s-ci-robot assigned aleksandra-malinowska and feiskyer May 26, 2021

feiskyer approved these changes May 27, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021

feat(cloudprovider.rancher): Add owners file.

5c25f94

k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 27, 2021

fix(cloudprovider.rancher): fix typo

9a8c4e7

Update OWNERS

5904ddb

Delete OWNERS

f1978a7

k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 1, 2021

Jeffwan reviewed Oct 1, 2021

View reviewed changes

jose-cieni-afterverse mentioned this pull request Oct 7, 2021

Retiring our Rancher fork Afterverse/kubernetes-autoscaler#5

Merged

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 19, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2022

kgeipel-retail7 mentioned this pull request Feb 18, 2022

Rancher 2 node template auto scaling group (ASG) support rancher/rancher#15305

Open

mwielgus closed this May 17, 2022

ctrox mentioned this pull request Jun 15, 2022

Add cloud provider for Rancher with RKE2 #4975

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Rancher as a cloud provider #4041

Add Rancher as a cloud provider #4041

douglasmakey commented Apr 27, 2021

k8s-ci-robot commented Apr 27, 2021

k8s-ci-robot commented Apr 27, 2021

mwielgus left a comment

douglasmakey commented May 25, 2021

reylejano commented May 26, 2021

feiskyer left a comment

k8s-ci-robot commented May 27, 2021

douglasmakey commented May 27, 2021

douglasmakey commented Oct 1, 2021

Jeffwan Oct 1, 2021

Jeffwan Oct 1, 2021

Jeffwan Oct 1, 2021

Jeffwan Oct 1, 2021

Jeffwan commented Oct 1, 2021

k8s-ci-robot commented Oct 25, 2021

xrl commented Nov 19, 2021

reylejano commented Nov 19, 2021

xrl commented Nov 19, 2021 •

edited

Loading

k8s-triage-robot commented Feb 17, 2022

patrickdappollonio commented Feb 17, 2022

leodotcloud commented Feb 17, 2022

leodotcloud commented Feb 17, 2022

mwielgus commented May 17, 2022

glermaidt commented Jun 3, 2022

patrickdappollonio commented Jun 3, 2022

cambierr commented Jun 3, 2022 via email

glermaidt commented Jun 4, 2022

cambierr commented Jun 5, 2022 via email

rodcloutier commented Jun 14, 2022

ctrox commented Jun 15, 2022

Add Rancher as a cloud provider #4041

Add Rancher as a cloud provider #4041

Conversation

douglasmakey commented Apr 27, 2021

k8s-ci-robot commented Apr 27, 2021

k8s-ci-robot commented Apr 27, 2021

mwielgus left a comment

Choose a reason for hiding this comment

douglasmakey commented May 25, 2021

reylejano commented May 26, 2021

feiskyer left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 27, 2021

douglasmakey commented May 27, 2021

douglasmakey commented Oct 1, 2021

Jeffwan Oct 1, 2021

Choose a reason for hiding this comment

Jeffwan Oct 1, 2021

Choose a reason for hiding this comment

Jeffwan Oct 1, 2021

Choose a reason for hiding this comment

Jeffwan Oct 1, 2021

Choose a reason for hiding this comment

Jeffwan commented Oct 1, 2021

k8s-ci-robot commented Oct 25, 2021

xrl commented Nov 19, 2021

reylejano commented Nov 19, 2021

xrl commented Nov 19, 2021 • edited Loading

k8s-triage-robot commented Feb 17, 2022

patrickdappollonio commented Feb 17, 2022

leodotcloud commented Feb 17, 2022

leodotcloud commented Feb 17, 2022

mwielgus commented May 17, 2022

glermaidt commented Jun 3, 2022

patrickdappollonio commented Jun 3, 2022

cambierr commented Jun 3, 2022 via email

glermaidt commented Jun 4, 2022

cambierr commented Jun 5, 2022 via email

rodcloutier commented Jun 14, 2022

ctrox commented Jun 15, 2022

xrl commented Nov 19, 2021 •

edited

Loading