Add more buckets to admission_latency_seconds metric #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/XS
I want more resolution in [0.2, 1]s range. For K8s Pod Creation Latency SLO[1] has a target of 5s so it makes a difference for the SLO how the delay we introduce is distributed. Right now I think buckets are too wide. [1] https://github.com/kubernetes/community/blob/master/sig-scalability/slos/pod_startup_latency.md
jbartosik
force-pushed
the
more_admission_latency_buckets
branch
from
8cc606b to
4fbd0d8
Compare
k8s-ci-robot
added
the
approved
josephburnett
approved these changes
Feb 1, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, josephburnett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want more resolution in [0.2, 1]s range. K8s Pod Creation Latency
SLO has a target of 5s so it makes a difference for the SLO how the
delay we introduce is distributed. Right now I think buckets are too
wide in the [0.1, 1]s range.
/kind feature