Skip to content

Commit

Permalink
Add more buckets to admission_latency_seconds metric
Browse files Browse the repository at this point in the history
I want more resolution in [0.2, 1]s range. For K8s Pod Creation Latency
SLO[1] has a target of 5s so it makes a difference for the SLO how the
delay we introduce is distributed. Right now I think buckets are too
wide.

[1] https://github.com/kubernetes/community/blob/master/sig-scalability/slos/pod_startup_latency.md
  • Loading branch information
jbartosik committed Feb 1, 2022
1 parent 7b3ce42 commit 4fbd0d8
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ var (
Namespace: metricsNamespace,
Name: "admission_latency_seconds",
Help: "Time spent in VPA Admission Controller.",
Buckets: []float64{0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1.0, 2.0, 5.0, 10.0, 20.0, 30.0, 60.0, 120.0, 300.0},
Buckets: []float64{0.01, 0.02, 0.05, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0, 2.0, 5.0, 10.0, 20.0, 30.0, 60.0, 120.0, 300.0},
}, []string{"status", "resource"},
)
)
Expand Down

0 comments on commit 4fbd0d8

Please sign in to comment.