Skip iteration loop if node creation failed #4143
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
| @@ -346,7 +346,10 @@ func (a *StaticAutoscaler) RunOnce(currentTime time.Time) errors.AutoscalerError | |||
| return nil | |||
| } | |||
|
|
|||
| a.deleteCreatedNodesWithErrors() | |||
| if a.deleteCreatedNodesWithErrors() { | |||
| klog.V(0).Infof("Creation of some nodes failed, deleting them and skipping iteration") | |||
There was a problem hiding this comment.
nit: I think the wording is a bit misleading - it suggests CA tried to create nodes this loop and failed. Maybe "Removed some nodes that failed to create, skipping iteration"?
There was a problem hiding this comment.
Done, changed to "Some nodes that failed to create were removed, skipping iteration" for consistency with the similar log above.
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BigDarkClown, MaciekPytel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Skip iteration loop if node creation failed
Skip iteration loop if node creation failed
Skip iteration loop if node creation failed
Skip iteration loop if node creation failed
In case of stockout or quota issue CA will watch for nodes with create errors and delete them. After deletion it will continue the loop normally. However, it will not trigger any sort of clusterstate recalculation and the deleted nodes will still be counted as upcoming and the rest of CA logic will continue expecting them to come up.
Similar logic that handles nodes that timed out will break CA loop instead. This seems like a more correct behaviour.