cluster autoscaler patch cluster autoscaler 1.19.2 airbnb2 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmorr0
approved these changes
Sep 8, 2022
Skip iteration loop if node creation failed
…hErrors-no-segfault Don't deref nil nodegroup in deleteCreatedNodesWithErrors
evansheng
force-pushed
the
evan_sheng--cluster-autoscaler-patch-cluster-autoscaler-1.19.2-airbnb2
branch
from
1f8adaa to
f2f5923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 new patches to our fork for 1.19
This will resolve the segfaults we've been seeing in CA when there are a large amount of nodes AWS cannot fulfill.
equivalent PR for 1.20 coming soon
@drmorr0