-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: CA does not work properly while using AWS EC2 IMDSv2 #4127
Fix: CA does not work properly while using AWS EC2 IMDSv2 #4127
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
accepted CLA |
@gjtempleton can you please take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I have one minor nit on expanding the docs, but other than that, this looks good.
Co-authored-by: Guy Templeton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this @darkpssngr.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darkpssngr, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This fixes #3592.
We use the aws sdk to fetch the metadata. The endpoint explicitly set to
"http://169.254.169.254"
so that tests don't fail.We tested it by applying these changes in 1.18.3 and it worked fine. tested both scale up and scale down.
This was tested in instances with IMDsV1 enabled and disabled.