Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CA does not work properly while using AWS EC2 IMDSv2 #4127

Merged
merged 3 commits into from
Jul 22, 2021

Conversation

darkpssngr
Copy link
Contributor

This fixes #3592.
We use the aws sdk to fetch the metadata. The endpoint explicitly set to "http://169.254.169.254" so that tests don't fail.

We tested it by applying these changes in 1.18.3 and it worked fine. tested both scale up and scale down.

This was tested in instances with IMDsV1 enabled and disabled.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and Jeffwan June 9, 2021 05:56
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2021
@darkpssngr
Copy link
Contributor Author

accepted CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 9, 2021
@darkpssngr
Copy link
Contributor Author

@Jeffwan @feiskyer could you please take a look at this? Not sure if something's pending from my end.

@mwielgus mwielgus requested a review from gjtempleton June 21, 2021 13:47
@darkpssngr
Copy link
Contributor Author

@gjtempleton can you please take a look at this?

Copy link
Member

@gjtempleton gjtempleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I have one minor nit on expanding the docs, but other than that, this looks good.

cluster-autoscaler/cloudprovider/aws/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this @darkpssngr.

@jaypipes
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darkpssngr, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0946e38 into kubernetes:master Jul 22, 2021
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
…999-#4199-upstream-cluster-autoscaler-release-1.19

Automated cherry pick of #3999 #4127 #4199 upstream cluster autoscaler release 1.19
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
…999-#4199-upstream-cluster-autoscaler-release-1.20

Automated cherry pick of #3999 #4127 #4199 upstream cluster autoscaler release 1.20
k8s-ci-robot added a commit that referenced this pull request Aug 17, 2021
…999-#4199-upstream-cluster-autoscaler-release-1.21

Automated cherry pick of #3999 #4127 #4199 upstream cluster autoscaler release 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA does not work properly while using AWS EC2 IMDSv2 only in EKS
5 participants