Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.19.2 Does not start without env AWS_REGION #4389

Closed
vainu-lauri opened this issue Oct 7, 2021 · 8 comments
Closed

1.19.2 Does not start without env AWS_REGION #4389

vainu-lauri opened this issue Oct 7, 2021 · 8 comments
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@vainu-lauri
Copy link

vainu-lauri commented Oct 7, 2021 •
edited
Loading

Which component are you using?:

eu.gcr.io/k8s-artifacts-prod/autoscaling/cluster-autoscaler:v1.19.2

What version of the component are you using?:

v1.19.2

What k8s version are you using (kubectl version)?:

kubectl version Output
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.1", GitCommit:"632ed300f2c34f6d6d15ca4cef3d3c7073412212", GitTreeState:"clean", BuildDate:"2021-08-19T15:38:26Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.13-eks-8df270", GitCommit:"8df2700a72a2598fa3a67c05126fa158fd839620", GitTreeState:"clean", BuildDate:"2021-07-31T01:36:57Z", GoVersion:"go1.15.14", Compiler:"gc", Platform:"linux/amd64"}

What environment is this in?:

AWS

What did you expect to happen?:
Upgrade from 1.19.1 to 1.19.2 to work with existing configuration.

What happened instead?:
The 1.19.2 crashes with following:

F1006 07:46:04.699353       1 aws_cloud_provider.go:353] Failed to get AWS Region: EC2MetadataRequestError: failed to get EC2 instance identity document
caused by: EC2MetadataError: failed to make EC2Metadata request
        status code: 404, request id:
caused by: <?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
                 "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
  <title>404 - Not Found</title>
 </head>
 <body>
  <h1>404 - Not Found</h1>
 </body>
</html>

How to reproduce it (as minimally and precisely as possible):
Upgrade from 1.19.1 to 1.19.2 and do not have AWS_REGION environment variable set.

Anything else we need to know?:
I think this is due to change introduced in #4127 which was cherry-picked to 1.19.2 (and others) in PR #4265

It seems that there is a bug with the current version of github.com/aws/aws-sdk-go v1.28.2 in 1.19.2.

I tested the GetCurrentAwsRegion() with that and it indeed seems to fail with the same 404. Although a newer version like github.com/aws/aws-sdk-go v1.40.57 works as it should.

This probably affects other releases of cluster-autoscaler as well.
@vainu-lauri vainu-lauri added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2021
@gjtempleton
Copy link
Member

gjtempleton commented Oct 13, 2021 •
edited
Loading

Hey, thanks for raising this.

With a bit of testing it appears this only affects the 1.19.2 release as the 1.20 and onwards release branches are using v1.35.24 or newer of the AWS SDK due to the upstream Kubernetes dependencies being updated and these versions don't seem to have the same issue.

I'll see if we can get a PR in to update the SDK enough to resolve this for the 1.19 release branch.

/area provider/aws

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Oct 13, 2021
@gjtempleton gjtempleton mentioned this issue Oct 14, 2021
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2022
@tyen-brex
Copy link

tyen-brex commented Jan 26, 2022 •
edited
Loading

Hi, is there a tagged 1.19 release with this fix?

@mdkent
Copy link

mdkent commented Jan 27, 2022

Bumping as well, hitting this crash while upgrading a cluster to 1.19.

@tchristie-meazure
Copy link

Getting a similar issue as well, but I am getting a 401 - not a 404.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2022
@robisoh88 robisoh88 mentioned this issue Mar 11, 2022
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@mdkent @jbartosik @gjtempleton @k8s-ci-robot @vainu-lauri @k8s-triage-robot @tchristie-meazure @tyen-brex