Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module rename: sigs.k8s.io/k8s-container-image-promoter --> sigs.k8s.io/promo-tools #428

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Module rename: sigs.k8s.io/k8s-container-image-promoter --> sigs.k8s.io/promo-tools
This will happen today in coordination with the repo rename AND branch rename to main.

We'll lock in the renames first and sweep "non-code" references in a follow-up.
PR has been opened to update test-infra job references: kubernetes/test-infra#23605

Tracking issue: #424

/assign @puerco @cpanato @ameukam @Verolop
cc: @kubernetes-sigs/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Module rename: sigs.k8s.io/k8s-container-image-promoter --> sigs.k8s.io/promo-tools

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/k8s-infra labels Sep 15, 2021
@justaugustus
Copy link
Member Author

/hold for coordinating the peeps + approvals

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2021
@puerco
Copy link
Member

puerco commented Sep 15, 2021

Weeeeee 🚀
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2021
@cpanato
Copy link
Member

cpanato commented Sep 15, 2021

/lgtm

@justaugustus
Copy link
Member Author

/hold cancel
Both this and kubernetes/test-infra#23605 have been approved.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6c74cdb into kubernetes-sigs:master Sep 15, 2021
@justaugustus justaugustus mentioned this pull request Oct 2, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants