-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename repo and default branch #424
Comments
Votes so far:
|
Notice to k-dev: https://groups.google.com/g/kubernetes-dev/c/YnIYtEBURvk |
Opened a PR for the repo rename: kubernetes/test-infra#23605 |
Will be completed via kubernetes/k8s.io#2752. |
@justaugustus: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added:
As we start to integrate promotion tools back into the image promoter repo, I'd like to take the opportunity to:
As both of those touch roughly the same files, I'd like to handle them together.
I have two ideas for repo names, so let's vote!
sigs.k8s.io/kpromo
(the name of the artifact promotion CLI tool)sigs.k8s.io/promo-tools
For other name suggestions, comment here or on this thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1631538346069100
Why is this needed
main
kubernetes/org#2222Default Branch Migration
(Copied from https://k8s.dev/rename)
This document outlines steps needed to migrate the default branch
of your repo from
master
tomain
.Note: This document is currently a work in progress.
If you have questions about the process, reach out to the GitHub Management Team
on the #github-management channel on slack or open an issue in the kubernetes/org repo.
Prerequisites
approver for approval
mailing list about the potential branch rename: https://groups.google.com/g/kubernetes-dev/c/YnIYtEBURvk
Changes pre-rename
Make the following changes before renaming the branch the
master
branch.Note: There might be additional changes required that have not been
covered in this checklist.
Anytime
These changes are non-disruptive and can be made anytime before renaming
the branch.
If a presubmit or postsubmit prowjob triggers on the
master
branch(
branches
field of the prowjob), add themain
branch to the list(see kubernetes/test-infra#20665 for an example): SIG Release cleanups kubernetes/test-infra#23332
(N/A)
If themilestone_applier
prow config references themaster
branch,add the
main
branch to the config (see kubernetes/test-infra#20675 for an example).(N/A)
If thebranch_protection
prow config references themaster
branch,add the
main
branch to the config.Just before rename
These changes are disruptive and should be made just before renaming the
branch.
(N/A) For periodic prowjobs, or any prowjob that mentions the
master
branchin
base_ref
, update them to themain
branch. Ensure that these changeshappen in lock-step with the branch rename (jobs triggered in between landing
these changes and renaming the branch will fail).
e.g.
kubernetes/foo=main
. kubernetes/test-infra#20667 may eventuallyallow for non-disruptive changes.
e.g.
base_ref: main
. kubernetes/test-infra#20672 may eventually allowfor non-disruptive changes.
(N/A) If a prowjob mentions
master
in its name, rename the job to not includethe branch name, e.g.
pull-repo-verify-master
->pull-repo-verify
.status-reconciler
should automatically migrate PR status contexts to thenew job name, and retrigger accordingly, but we have anecdotally found it
sometimes misses changes.
from the perspective of e.g. https://testgrid.k8s.io the job will appear to
have lost history and start from scratch.
(N/A) If a prowjob calls scripts or code in your repo that explicitly
reference
master
, update all references to usemain
, or auto-detect theremote branch
(N/A) If the repo has netlify configured for it, ask a member of the GitHub
Management Team to rename the
master
branch tomain
in the netlify site config.It can't be controlled through the netlify config in the repo.
Approval
have been identified, assign the GitHub Management team (@kubernetes/owners)
for approval.
Rename the default branch
master
tomain
using the GitHub UIby following the official instructions.
Changes post-rename
After the default branch has been renamed to
main
, make the followingchanges.
Note: There might be additional changes required that have not been
covered in this checklist.
Prowjobs
master
branch in thebranches
field,remove the
master
branch (see kubernetes/test-infra#20669 for an example): releng: Post-rename tasks for sigs.k8s.io/promo-tools kubernetes/test-infra#23626Prow config
(N/A) If the
milestone_applier
prow config references themaster
branch,remove it from the config.
(N/A) If the
branch_protection
prow config references themaster
branch,remove it from the config.
Other
If any docs reference the
master
branch, update tomain
(URLs will be automatically redirected)
Ensure that CI and PR tests work fine.
that presubmits and postsubmits work as expected:
Trial the local development experience with a pre-rename clone.
have git autocompletion enabled, typing
ma<tab>
will autocomplete tomain
Send a notice about the branch rename to your SIG's mailing list.
Include the link to the GitHub instructions to rename your local branch: https://groups.google.com/g/kubernetes-dev/c/YnIYtEBURvk/m/lF7DCIGmBwAJ
cs.k8s.io references
/assign
cc: @kubernetes-sigs/release-engineering
The text was updated successfully, but these errors were encountered: