Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecation warning for a few RNode helpers #4328

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Dec 3, 2021

The Pipe method is not as intuitive as these helpers. These helpers
are convenient and useful. Deprecating them before we have better
alternatives is premature.

The Pipe method is not as intuitive as these helpers. These helpers
are convenient and useful. Deprecating them before we have better
alternatives is premature.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2021
@mengqiy
Copy link
Member Author

mengqiy commented Dec 3, 2021

/uncc mortent
/cc @natasha41575 @KnVerey

@k8s-ci-robot k8s-ci-robot requested review from KnVerey and natasha41575 and removed request for mortent December 3, 2021 19:56
@natasha41575
Copy link
Contributor

What do you envision for the future of these helpers and pipes? IIRC the reason for deprecating them was due to redundancy, do we eventually plan to remove one or the other or would we keep them both?

@mengqiy
Copy link
Member Author

mengqiy commented Dec 3, 2021

We want to deprecate and remove these 3 methods eventually. We will keep Pipe.
I imagine we can start to deprecate these 3 methods again after we merge #4319.
With #4319, we will provide only one function for fn developers to get a field: http://104.197.156.154/pkg/sigs.k8s.io/kustomize/kyaml/fn/framework/#KubeObject.Get

@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit bc3b249 into kubernetes-sigs:master Dec 3, 2021
@mengqiy mengqiy deleted the undeprecate branch December 3, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants