Skip to content

Commit

Permalink
Merge pull request #4328 from mengqiy/undeprecate
Browse files Browse the repository at this point in the history
Remove the deprecation warning for a few RNode helpers
  • Loading branch information
k8s-ci-robot authored Dec 3, 2021
2 parents 8c6af94 + cd2c6a1 commit bc3b249
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions kyaml/yaml/rnode.go
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,6 @@ func checkKey(key string, elems []*Node) bool {
return count == len(elems)
}

// Deprecated: use pipes instead.
// GetSlice returns the contents of the slice field at the given path.
func (rn *RNode) GetSlice(path string) ([]interface{}, error) {
value, err := rn.GetFieldValue(path)
Expand All @@ -1076,7 +1075,6 @@ func (rn *RNode) GetSlice(path string) ([]interface{}, error) {
return nil, fmt.Errorf("node %s is not a slice", path)
}

// Deprecated: use pipes instead.
// GetString returns the contents of the string field at the given path.
func (rn *RNode) GetString(path string) (string, error) {
value, err := rn.GetFieldValue(path)
Expand All @@ -1089,7 +1087,6 @@ func (rn *RNode) GetString(path string) (string, error) {
return "", fmt.Errorf("node %s is not a string: %v", path, value)
}

// Deprecated: use slash paths instead.
// GetFieldValue finds period delimited fields.
// TODO: When doing kustomize var replacement, which is likely a
// a primary use of this function and the reason it returns interface{}
Expand Down

0 comments on commit bc3b249

Please sign in to comment.