[Kjobctl] Extend priority flag to other modes #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/L
|
/assign @mbobrovskyi @IrvingMg |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
mbobrovskyi
reviewed
Oct 10, 2024
cmd/experimental/kjobctl/apis/v1alpha1/application_profile_types.go
Outdated
Show resolved
Hide resolved
cmd/experimental/kjobctl/docs/commands/kjobctl_create/kjobctl_create_job.md
Outdated
Show resolved
Hide resolved
IrvingMg
reviewed
Oct 10, 2024
cmd/experimental/kjobctl/apis/v1alpha1/application_profile_types.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Oct 11, 2024
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
mbobrovskyi
reviewed
Oct 11, 2024
cmd/experimental/kjobctl/apis/v1alpha1/application_profile_types.go
Outdated
Show resolved
Hide resolved
mszadkow
force-pushed
the
feature/kjobctl-priority-flags-other-builders
branch
3 times, most recently
from
01290a6 to
eea63b1
Compare
mwielgus
reviewed
Oct 11, 2024
cmd/experimental/kjobctl/apis/v1alpha1/application_profile_types.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Oct 14, 2024
mszadkow
force-pushed
the
feature/kjobctl-priority-flags-other-builders
branch
from
829be00 to
3642517
Compare
mbobrovskyi
reviewed
Oct 14, 2024
cmd/experimental/kjobctl/apis/v1alpha1/application_profile_types.go
Outdated
Show resolved
Hide resolved
mszadkow
force-pushed
the
feature/kjobctl-priority-flags-other-builders
branch
2 times, most recently
from
80494bd to
8339329
Compare
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: aeef0e03bf486491fd232e6b848a7f8e0d240b31
|
k8s-ci-robot
added
the
needs-rebase
|
@mszadkow please rebase |
|
/cc @mwysokin |
|
@mimowo: GitHub didn't allow me to request PR reviews from the following users: mwysokin. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mszadkow
force-pushed
the
feature/kjobctl-priority-flags-other-builders
branch
from
8339329 to
c59e4be
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 490ee2f4588e9ba1eb73179c3bf1dd164d5ad85b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mszadkow, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
PBundyra
pushed a commit
to PBundyra/kueue
that referenced
this pull request
Nov 5, 2024
* extend priority flag to other modes * Update after code review * Unify priority flag for all modes * Move priority flag check to common place
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
* extend priority flag to other modes * Update after code review * Unify priority flag for all modes * Move priority flag check to common place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Extend priority flag to other modes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?