Update after code review

cmd/experimental/kjobctl/apis/v1alpha1/application_profile_types.go

@@ -93,8 +93,7 @@ type TemplateReference string
 // +kubebuilder:validation:XValidation:rule="!has(self.requiredFlags) || !('ntasks' in self.requiredFlags) || self.name == 'Slurm'", message="ntasks flag can be used only on Slurm mode"
 // +kubebuilder:validation:XValidation:rule="!has(self.requiredFlags) || !('output' in self.requiredFlags) || self.name == 'Slurm'", message="output flag can be used only on Slurm mode"
 // +kubebuilder:validation:XValidation:rule="!has(self.requiredFlags) || !('partition' in self.requiredFlags) || self.name == 'Slurm'", message="partition flag can be used only on Slurm mode"
-// +kubebuilder:validation:XValidation:rule="!has(self.requiredFlags) || !('priority' in self.requiredFlags) || self.name != 'Interactive'", message="priority flag can't be used only on Interactive mode"
-// +kubebuilder:validation:XValidation:rule="!has(self.requiredFlags) || !('skip-priority-validation' in self.requiredFlags) || self.name != 'Interactive'", message="skip priority validation flag can't be used only on Interactive mode"
+// +kubebuilder:validation:XValidation:rule="!has(self.requiredFlags) || !('priority' in self.requiredFlags) || self.name != 'Interactive'", message="priority flag can't be used on Interactive mode"
 // +kubebuilder:validation:XValidation:rule="!has(self.requiredFlags) || self.name != 'Slurm' || !('parallelism' in self.requiredFlags)", message="parallelism flag can't be used on Slurm mode"
 // +kubebuilder:validation:XValidation:rule="!has(self.requiredFlags) || self.name != 'Slurm' || !('completions' in self.requiredFlags)", message="completions flag can't be used on Slurm mode"
 type SupportedMode struct {
@@ -131,7 +130,7 @@ type SupportedMode struct {
 	//
 	// +optional
 	// +listType=set
-	// +kubebuilder:validation:MaxItems=14
+	// +kubebuilder:validation:MaxItems=13
 	RequiredFlags []Flag `json:"requiredFlags,omitempty"`
 }
 

cmd/experimental/kjobctl/config/crd/bases/kjobctl.x-k8s.io_applicationprofiles.yaml

@@ -93,7 +93,7 @@ spec:
                         - output
                         - partition
                         type: string
-                      maxItems: 14
+                      maxItems: 13
                       type: array
                       x-kubernetes-list-type: set
                     template:
@@ -184,13 +184,9 @@ spec:
                   - message: partition flag can be used only on Slurm mode
                     rule: '!has(self.requiredFlags) || !(''partition'' in self.requiredFlags)
                       || self.name == ''Slurm'''
-                  - message: priority flag can't be used only on Interactive mode
+                  - message: priority flag can't be used on Interactive mode
                     rule: '!has(self.requiredFlags) || !(''priority'' in self.requiredFlags)
                       || self.name != ''Interactive'''
-                  - message: skip priority validation flag can't be used only on Interactive
-                      mode
-                    rule: '!has(self.requiredFlags) || !(''skip-priority-validation''
-                      in self.requiredFlags) || self.name != ''Interactive'''
                   - message: parallelism flag can't be used on Slurm mode
                     rule: '!has(self.requiredFlags) || self.name != ''Slurm'' || !(''parallelism''
                       in self.requiredFlags)'

cmd/experimental/kjobctl/docs/commands/kjobctl_create/kjobctl_create_job.md

@@ -12,7 +12,7 @@ The file is auto-generated from the Go source code of the component using the
 Create a job
 
 ```
-kjobctl create job --profile APPLICATION_PROFILE_NAME [--localqueue LOCAL_QUEUE_NAME] [--skip-localqueue-validation] [--skip-priority-validation] [--cmd COMMAND] [--request RESOURCE_NAME=QUANTITY] [--parallelism PARALLELISM] [--completions COMPLETIONS] [--priority NAME]
+kjobctl create job --profile APPLICATION_PROFILE_NAME [--localqueue LOCAL_QUEUE_NAME] [--skip-localqueue-validation] [--cmd COMMAND] [--request RESOURCE_NAME=QUANTITY] [--parallelism PARALLELISM] [--completions COMPLETIONS] [--priority NAME] [--skip-priority-validation]
 ```
 
 

cmd/experimental/kjobctl/docs/commands/kjobctl_create/kjobctl_create_raycluster.md

@@ -14,7 +14,7 @@ Create a raycluster.
  KubeRay operator is required for RayCluster. How to install KubeRay operator you can find here https://ray-project.github.io/kuberay/deploy/installation/.
 
 ```
-kjobctl create raycluster --profile APPLICATION_PROFILE_NAME [--localqueue LOCAL_QUEUE_NAME] [--skip-localqueue-validation] [--skip-priority-validation] [--replicas [WORKER_GROUP]=REPLICAS] [--min-replicas [WORKER_GROUP]=MIN_REPLICAS] [--max-replicas [WORKER_GROUP]=MAX_REPLICAS] [--priority NAME]
+kjobctl create raycluster --profile APPLICATION_PROFILE_NAME [--localqueue LOCAL_QUEUE_NAME] [--skip-localqueue-validation] [--replicas [WORKER_GROUP]=REPLICAS] [--min-replicas [WORKER_GROUP]=MIN_REPLICAS] [--max-replicas [WORKER_GROUP]=MAX_REPLICAS] [--priority NAME] [--skip-priority-validation]
 ```
 
 

cmd/experimental/kjobctl/docs/commands/kjobctl_create/kjobctl_create_rayjob.md

@@ -14,7 +14,7 @@ Create a rayjob.
  KubeRay operator is required for RayJob. How to install KubeRay operator you can find here https://ray-project.github.io/kuberay/deploy/installation/.
 
 ```
-kjobctl create rayjob --profile APPLICATION_PROFILE_NAME [--localqueue LOCAL_QUEUE_NAME] [--skip-localqueue-validation] [--skip-priority-validation] [--cmd COMMAND] [--replicas [WORKER_GROUP]=REPLICAS] [--min-replicas [WORKER_GROUP]=MIN_REPLICAS] [--max-replicas [WORKER_GROUP]=MAX_REPLICAS] [--priority NAME]
+kjobctl create rayjob --profile APPLICATION_PROFILE_NAME [--localqueue LOCAL_QUEUE_NAME] [--skip-localqueue-validation] [--cmd COMMAND] [--replicas [WORKER_GROUP]=REPLICAS] [--min-replicas [WORKER_GROUP]=MIN_REPLICAS] [--max-replicas [WORKER_GROUP]=MAX_REPLICAS] [--priority NAME] [--skip-priority-validation]
 ```
 
 

cmd/experimental/kjobctl/pkg/builder/builder.go

@@ -313,14 +313,11 @@ func (b *Builder) validateGeneral(ctx context.Context) error {
 		}
 	}
 
-	// priority class is checked excluding interactive mode
-	if b.modeName != v1alpha1.InteractiveMode {
-		// check that priority class exists
-		if len(b.priority) != 0 && !b.skipPriorityValidation {
-			_, err := b.kueueClientset.KueueV1beta1().WorkloadPriorityClasses().Get(ctx, b.priority, metav1.GetOptions{})
-			if err != nil {
-				return err
-			}
+	// check that priority class exists
+	if len(b.priority) != 0 && !b.skipPriorityValidation {
+		_, err := b.kueueClientset.KueueV1beta1().WorkloadPriorityClasses().Get(ctx, b.priority, metav1.GetOptions{})
+		if err != nil {
+			return err
 		}
 	}
 

cmd/experimental/kjobctl/pkg/cmd/create/create.go

@@ -239,12 +239,12 @@ var createModeSubcommands = map[string]modeSubcommand{
 	"job": {
 		ModeName: v1alpha1.JobMode,
 		Setup: func(clientGetter util.ClientGetter, subcmd *cobra.Command, o *CreateOptions) {
-			subcmd.Use += " [--skip-priority-validation]" +
-				" [--cmd COMMAND]" +
+			subcmd.Use += " [--cmd COMMAND]" +
 				" [--request RESOURCE_NAME=QUANTITY]" +
 				" [--parallelism PARALLELISM]" +
 				" [--completions COMPLETIONS]" +
-				" [--priority NAME]"
+				" [--priority NAME]" +
+				" [--skip-priority-validation]"
 			subcmd.Short = "Create a job"
 			subcmd.Example = createJobExample
 
@@ -285,12 +285,12 @@ var createModeSubcommands = map[string]modeSubcommand{
 	"rayjob": {
 		ModeName: v1alpha1.RayJobMode,
 		Setup: func(clientGetter util.ClientGetter, subcmd *cobra.Command, o *CreateOptions) {
-			subcmd.Use += " [--skip-priority-validation]" +
-				" [--cmd COMMAND]" +
+			subcmd.Use += " [--cmd COMMAND]" +
 				" [--replicas [WORKER_GROUP]=REPLICAS]" +
 				" [--min-replicas [WORKER_GROUP]=MIN_REPLICAS]" +
 				" [--max-replicas [WORKER_GROUP]=MAX_REPLICAS]" +
-				" [--priority NAME]"
+				" [--priority NAME]" +
+				" [--skip-priority-validation]"
 			subcmd.Short = "Create a rayjob"
 			subcmd.Long = createRayJobLong
 			subcmd.Example = createRayJobExample
@@ -319,11 +319,11 @@ var createModeSubcommands = map[string]modeSubcommand{
 	"raycluster": {
 		ModeName: v1alpha1.RayClusterMode,
 		Setup: func(clientGetter util.ClientGetter, subcmd *cobra.Command, o *CreateOptions) {
-			subcmd.Use += " [--skip-priority-validation]" +
-				" [--replicas [WORKER_GROUP]=REPLICAS]" +
+			subcmd.Use += " [--replicas [WORKER_GROUP]=REPLICAS]" +
 				" [--min-replicas [WORKER_GROUP]=MIN_REPLICAS]" +
 				" [--max-replicas [WORKER_GROUP]=MAX_REPLICAS]" +
-				" [--priority NAME]"
+				" [--priority NAME]" +
+				" [--skip-priority-validation]"
 			subcmd.Short = "Create a raycluster"
 			subcmd.Long = createRayClusterLong
 			subcmd.Example = createRayClusterExample