metallb: Add images to downloads

[sathieu]

What type of PR is this?
/kind feature

What this PR does / why we need it:

For offline mode

Does this PR introduce a user-facing change?:

[MetalLB] Add images to downloads

[k8s-ci-robot]

Hi @sathieu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sathieu]

/assign @woopstar

[cristicalin]

@sathieu 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, sathieu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cristicalin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sathieu]

@cristicalin Related question, why are core images not in downloads ?

Those are added manually in the script:

kubespray/contrib/offline/generate_list.sh

Lines 21 to 25 in 7e7218f

	# add kube-* images to images list template
	KUBE_IMAGES="kube-apiserver kube-controller-manager kube-scheduler kube-proxy"
	for i in $KUBE_IMAGES; do
	echo "{{ kube_image_repo }}/$i:{{ kube_version }}" >> ${TEMP_DIR}/images.list.template
	done

(And also in kubitus-installer).

[cristicalin]

@cristicalin Related question, why are core images not in downloads ?

I'm not sure to be honest but I'm guessing it has something to do with the fact that kubespray does not manage these images itself and it's kubeadm that deploys the manifests for them.

[oomichi]

@cristicalin Related question, why are core images not in downloads ?

I'm not sure to be honest but I'm guessing it has something to do with the fact that kubespray does not manage these images itself and it's kubeadm that deploys the manifests for them.

Yeah, that is right I think.
contrib/offline/generate_list.sh generates container image list from roles/download/defaults/main.yml and the file doesn't contain core images because kubeadm downloads and installs those images internally.

Anyways the change seems good for me, thank you for doing this.

/ok-to-test
/lgtm

[oomichi]

FYI: #8718 adds a comment to know the reason.