[calico] call calico checks early on to prevent altering the cluster #8707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
cristicalin
force-pushed
the
check_calico_encapsulation_early
branch
from
1cd7f39 to
4ee3b43
Compare
oomichi
reviewed
Apr 12, 2022
cristicalin
force-pushed
the
check_calico_encapsulation_early
branch
from
4ee3b43 to
f38cf55
Compare
…with bad configuration
cristicalin
force-pushed
the
check_calico_encapsulation_early
branch
from
f38cf55 to
a73ebb4
Compare
|
Thank you for updating. /lgtm |
k8s-ci-robot
added
the
lgtm
Quehenr
pushed a commit
to Quehenr/unstable-laboratory-infrastructure-kubespray
that referenced
this pull request
Apr 16, 2022
* master: metallb: Add images to downloads (kubernetes-sigs#8715) etcd: add etcd v3.5.3 for kubernetes 1.21+ (kubernetes-sigs#8712) [calico] call calico checks early on to prevent altering the cluster with bad configuration (kubernetes-sigs#8707)
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
…with bad configuration (kubernetes-sigs#8707)
floryut
added
kind/network
Closed
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 30, 2023
…with bad configuration (kubernetes-sigs#8707)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2023
…with bad configuration (kubernetes-sigs#8707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call calico checks early on to prevent altering the cluster with bad configuration
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR ensures that calico checks are called early in the playbooks so that deployment fails before it makes bad changes to live clusters. Additionally this adds a migration procedure in the kubespray docs for folks migrating from 2.18 and hitting changing defaults.
Which issue(s) this PR fixes:
Fixes #8691
Special notes for your reviewer:
Does this PR introduce a user-facing change?: