Add ETCD_EXPERIMENTAL_INITIAL_CORRUPT_CHECK flag to etcd config #8664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I'm guessing once 3.5.3 is out we should bump it and make it the default across the board even if we slightly break from release guidelines. Thanks @floryut ! /lgtm |
k8s-ci-robot
added
the
lgtm
Totally agree with that 👍 |
Quehenr
pushed a commit
to Quehenr/unstable-laboratory-infrastructure-kubespray
that referenced
this pull request
Apr 4, 2022
* master: (21 commits) Fix quotation of nerdctl_extra_flags (kubernetes-sigs#8668) fix: uninstall contailer engine if service is running (kubernetes-sigs#8662) fix disk controller type in Vagrantfile (kubernetes-sigs#8656) Add ETCD_EXPERIMENTAL_INITIAL_CORRUPT_CHECK flag to etcd config (kubernetes-sigs#8664) Update vagrant.md (kubernetes-sigs#8663) Add missing 2.10 ansible test (kubernetes-sigs#8665) [ansible] make ansible 5.x the new default version (kubernetes-sigs#8660) Run 0100-dhclient-hooks if dhcpclient is enabled (kubernetes-sigs#8658) terrform/openstack: Fix templating of ansible_ssh_common_args in no_floating.yml if used as TF module (kubernetes-sigs#8646) [ansible] add support for ansible 5 (ansible-core 2.12) (kubernetes-sigs#8512) [etcd] add 0 hash for arm v3.5.2 to prevent deployment failures Update cert-manager to v1.7.2 (kubernetes-sigs#8648) fix vagrant parameter (kubernetes-sigs#8650) Remove centos7 molecule while opensuse mirror is flaky Remove k8s module for ns creation Update kubernetes image to 2.18.1 Vagrantfile: add var to set ansible verbosity level (kubernetes-sigs#8639) Have ingress_controller and external_provisioner in upgrade-cluster.yml (kubernetes-sigs#8640) [sysctl] set fs.may_detach_mounts=1 even when CRIs don't set it themselves (kubernetes-sigs#8635) Fixed cluster roles for openstack cloud controller (kubernetes-sigs#8638) ...
k8s-ci-robot
pushed a commit
that referenced
this pull request
Apr 14, 2022
* As per this issue #8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
Closed
notCalle
pushed a commit
to notCalle/kubespray
that referenced
this pull request
Jun 8, 2022
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
unai-ttxu
pushed a commit
to Stratio/kubespray
that referenced
this pull request
Jun 21, 2022
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
notCalle
pushed a commit
to notCalle/kubespray
that referenced
this pull request
Sep 7, 2022
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 29, 2023
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 30, 2023
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2023
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2023
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
etcd 3.5.x has an issue, which can disturb production
https://groups.google.com/a/kubernetes.io/g/dev/c/B7gJs88XtQc/m/rSgNOzV2BwAJ?utm_medium=email&utm_source=footer
Which issue(s) this PR fixes:
etcd-io/etcd#13766 (comment)
Special notes for your reviewer:
This is a recommendation by sig-cluster-lifecycle team
https://kubernetes.slack.com/archives/C13J86Z63/p1648574650285699
Does this PR introduce a user-facing change?: