Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cert-manager to v1.7.2 #8648

Merged

Conversation

rtsp
Copy link
Member

@rtsp rtsp commented Mar 24, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:
Update cert-manager to v1.7.2

I've checked that https://github.com/cert-manager/cert-manager/releases/download/v1.7.0/cert-manager.yaml and https://github.com/cert-manager/cert-manager/releases/download/v1.7.2/cert-manager.yaml are compatible to each other and require only those change in my PR.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[cert-manager] Update cert-manager to v1.7.2

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2022
@oomichi
Copy link
Contributor

oomichi commented Mar 26, 2022

The change seems good for me.
To pass molecule_tests, please rebase this pull request on the latest master which contains #8644

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, rtsp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2022
@rtsp rtsp force-pushed the develop/cert-manager-v1.7.2 branch from 04d32d1 to 7395a11 Compare March 26, 2022 06:14
@jayonlau
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit a67e367 into kubernetes-sigs:master Mar 26, 2022
@floryut
Copy link
Member

floryut commented Mar 28, 2022

Thank you @rtsp 👍

Quehenr pushed a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Apr 4, 2022
* master: (21 commits)
  Fix quotation of nerdctl_extra_flags (kubernetes-sigs#8668)
  fix: uninstall contailer engine if service is running (kubernetes-sigs#8662)
  fix disk controller type in Vagrantfile (kubernetes-sigs#8656)
  Add ETCD_EXPERIMENTAL_INITIAL_CORRUPT_CHECK flag to etcd config (kubernetes-sigs#8664)
  Update vagrant.md (kubernetes-sigs#8663)
  Add missing 2.10 ansible test (kubernetes-sigs#8665)
  [ansible] make ansible 5.x the new default version (kubernetes-sigs#8660)
  Run 0100-dhclient-hooks if dhcpclient is enabled (kubernetes-sigs#8658)
  terrform/openstack: Fix templating of ansible_ssh_common_args in no_floating.yml if used as TF module (kubernetes-sigs#8646)
  [ansible] add support for ansible 5 (ansible-core 2.12) (kubernetes-sigs#8512)
  [etcd] add 0 hash for arm v3.5.2 to prevent deployment failures
  Update cert-manager to v1.7.2 (kubernetes-sigs#8648)
  fix vagrant parameter (kubernetes-sigs#8650)
  Remove centos7 molecule while opensuse mirror is flaky
  Remove k8s module for ns creation
  Update kubernetes image to 2.18.1
  Vagrantfile: add var to set ansible verbosity level (kubernetes-sigs#8639)
  Have ingress_controller and external_provisioner in upgrade-cluster.yml (kubernetes-sigs#8640)
  [sysctl] set fs.may_detach_mounts=1 even when CRIs don't set it themselves (kubernetes-sigs#8635)
  Fixed cluster roles for openstack cloud controller (kubernetes-sigs#8638)
  ...
@rtsp rtsp deleted the develop/cert-manager-v1.7.2 branch April 12, 2022 13:32
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants