Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove addon-resizer #8566

Merged
merged 1 commit into from
Feb 22, 2022
Merged

chore: remove addon-resizer #8566

merged 1 commit into from
Feb 22, 2022

Conversation

cyril-corbon
Copy link
Contributor

@cyril-corbon cyril-corbon commented Feb 19, 2022 •
edited by oomichi
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
remove addon-resizer from defaults because he's not used anymore.

Only metrics-server was using this image.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[metrics server] Remove addon-resizer from image list (no longer in use)

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cyril-corbon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2022
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO February 19, 2022 11:09
@cristicalin
Copy link
Contributor

  1. could you explain why we don't need this component anymore? who/what was using it before and it not needing it now?
  2. why bundle the indentation change with this drop?

@cyril-corbon
Copy link
Contributor Author

cyril-corbon commented Feb 20, 2022 •
edited
Loading

Only metrics-server was using this component before.
I removed it when I upgrade metrics-server to v0.5.2 (see: #8338)

My editor automatically lint the file 😅 I can revert it if you want 😊

@cristicalin
Copy link
Contributor

@cyril-corbon it would be good to not mix unrelated changes in a PR

@floryut
Copy link
Member

floryut commented Feb 21, 2022

Separate PR or at the very least a separate commit indeed 😄

@cyril-corbon
chore: remove addon-resizer
d576e32 
Signed-off-by: Cyril Corbon <[email protected]>
@cyril-corbon cyril-corbon force-pushed the chore/remove-addon-resizer branch from 7f38685 to d576e32 Compare February 21, 2022 18:24
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2022
@cyril-corbon
Copy link
Contributor Author

Fixed 😄

floryut
floryut approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyril-corbon Thanks 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-corbon, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@floryut floryut added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2022
@floryut
Copy link
Member

floryut commented Feb 22, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2022
@floryut floryut removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2022
@oomichi
Copy link
Contributor

oomichi commented Feb 22, 2022

nice cleanup

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit a088f49 into kubernetes-sigs:master Feb 22, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cyril-corbon @sakuraiyuta
chore: remove addon-resizer (kubernetes-sigs#8566)
0ee81e0 
Signed-off-by: Cyril Corbon <[email protected]>
@oomichi oomichi added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 28, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@cyril-corbon @LuckySB
chore: remove addon-resizer (kubernetes-sigs#8566)
a364297 
Signed-off-by: Cyril Corbon <[email protected]>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@cyril-corbon @LuckySB
chore: remove addon-resizer (kubernetes-sigs#8566)
7a784fa 
Signed-off-by: Cyril Corbon <[email protected]>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 22, 2023
@cyril-corbon @LuckySB
chore: remove addon-resizer (kubernetes-sigs#8566)
86921cf 
Signed-off-by: Cyril Corbon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@oomichi oomichi

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyril-corbon @k8s-ci-robot @cristicalin @floryut @oomichi