-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade metrics server to v0.5.2 #8338
feat: upgrade metrics server to v0.5.2 #8338
Conversation
Welcome @cyril-corbon! |
Hi @cyril-corbon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Judging from the failure in https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1920301169#L2895 I think this still needs some work. |
be56166
to
e6d4e65
Compare
e6d4e65
to
df44766
Compare
Signed-off-by: Cyril Corbon <[email protected]>
df44766
to
f8d3a3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating.
/lgtm
roles/kubernetes-apps/metrics_server/templates/metrics-server-deployment.yaml.j2
Show resolved
Hide resolved
roles/kubernetes-apps/metrics_server/templates/metrics-server-deployment.yaml.j2
Show resolved
Hide resolved
forgot to run tests. /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyril-corbon Thanks for the PR 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyril-corbon, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Cyril Corbon <[email protected]>
Signed-off-by: Cyril Corbon <[email protected]>
Signed-off-by: Cyril Corbon <[email protected]>
Signed-off-by: Cyril Corbon [email protected]
What type of PR is this?
kind feature
What this PR does / why we need it:
Bump metrics server to v0.5.2 and remove NET_BIND_SERVICE capabilities
see: https://github.com/kubernetes-sigs/metrics-server/releases/tag/v0.5.2
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: