-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DNS configuration when using resolvconf_mode='host_resolvconf' during scale #8361
Fix DNS configuration when using resolvconf_mode='host_resolvconf' during scale #8361
Conversation
Hi @unai-ttxu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
thanks for this fix @unai-ttxu ! /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unai-ttxu Great 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, unai-ttxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When
resolvconf_mode
is set tohost_resolvconf
,kubernetes/preinstall
role should be included afterk8s
installation. Bothcluster.yml
andupgrade-cluster.yml
include the role butscale.yml
playbook doesn't.That would cause that new nodes won't be properly configured to use
coredns
ornodelocaldns
in their dns configuration.Special notes for your reviewer:
I haven't openned an issue. If you consider it neccesary I will be gladed to open it.
Does this PR introduce a user-facing change?: