Fix tests following python change #7775
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
floryut
force-pushed
the
fix_tests
branch
5 times, most recently
from
d3b8b96 to
c31880d
Compare
k8s-ci-robot
added
size/M
floryut
force-pushed
the
fix_tests
branch
4 times, most recently
from
561e836 to
61166f4
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Oracle jobs running fine visible here for centos7 |
floryut
changed the title
|
https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/pipelines/334079328 so many green jobs 😍 |
| - { option: "name", value: "CentOS-{{ ansible_distribution_major_version }} - Extras" } | ||
| - { option: "enabled", value: "1" } | ||
| - { option: "gpgcheck", value: "0" } | ||
| - { option: "baseurl", value: "http://mirror.centos.org/centos/{{ ansible_distribution_major_version }}/extras/$basearch/" } | ||
| when: | ||
| - use_oracle_public_repo|default(true) | ||
| - '''ID="ol"'' in os_release.stdout_lines' |
There was a problem hiding this comment.
Is this task for oracle only?
If so, it is nice to have for Oracle in the task name.
There was a problem hiding this comment.
This fixes an issue to block merger gate.
It is better to solve here later if necessary.
/lgtm
There was a problem hiding this comment.
You're very right, I'll keep that in my change file, will commit a task name improvement in another PR 👍
k8s-ci-robot
added
the
lgtm
* Fix ansible detection for python3 and ubuntu * Fix oracle missing centos-extras repo for containerd/docker dependencies
* Fix ansible detection for python3 and ubuntu * Fix oracle missing centos-extras repo for containerd/docker dependencies
What type of PR is this?
/kind bug
What this PR does / why we need it:
Following this PR (#7769), some ubuntu jobs are now longer working, this will fix that.
This PR also fix oracle jobs which was missing centos extra for container dependencies.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: