Ubuntu changed package name python-apt to python3-apt

[Shinerrs]

/kind feature

What this PR does / why we need it:
Looking forward to next Ubuntu Version you need do change the package name of python-apt in python3-apt.

Issue was resolved for ubuntu20.04.yml but not ubuntu.yml

Original issue that fixed only 1 of the ubuntu variable files: #7715

[k8s-ci-robot]

Welcome @Shinerrs!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Shinerrs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[oomichi]

/check-cla

[Shinerrs]

/check-cla

[floryut]

Well then https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes/preinstall/vars/ubuntu-21.04.yml should be removed, but are you positive that this work with ubuntu 16/18 etc.. ?

[Shinerrs]

Hey floryut,

Ive not tested those versions, I am using an ubuntu ami in AWS and it works there. I think supporting 16 is not feasible as no product should support something that is EoL 16.04 April 30th 2021. 18 is a great question and I will test this today.

But in any case, even if it does not work, it begs to question, why is Kubespray forcing the use of a python2 version that is EoL and could contain vulnerabilities, one would beg to question, is this kubespray a production grade or not.

Confirmed as a stopper to latest ubuntu build and this fixed it.

[floryut]

But in any case, even if it does not work, it begs to question, why is Kubespray forcing the use of a python2 version that is EoL and could contain vulnerabilities, one would beg to question, is this kubespray a production grade or not.

Not necessarily going down that road 😄 just wondering if this change should target only ubuntu 20 or also 18/16
I've trigger some ubuntu jobs on your PR to check also on CI end if everything works fine

[Shinerrs]

hehe :) my opinion is, anyone who uses EoL in production should go to jail, but everyone is entitled to their opinion xD

For my own future understanding, how would one (being me) trigger the build jobs in future?

[Shinerrs]

Interesting, the job failed in bash: /usr/bin/python: No such file or directory" for check_apiserver. Hrm....

Focusing on this pull request:

[0;32mok: [instance-1] => (item=/builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubernetes/preinstall/vars/../vars/ubuntu.yml) => {"ansible_facts": {"required_pkgs": ["python3-apt", "aufs-tools", "apt-transport-https", "software-properties-common", "conntrack"]}, "ansible_included_var_files": ["/builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubernetes/preinstall/vars/ubuntu.yml"], "ansible_loop_var": "item", "changed": false, "item": "/builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubernetes/preinstall/vars/../vars/ubuntu.yml"}�[0m �[0;32mok: [instance-2] => (item=/builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubernetes/preinstall/vars/../vars/ubuntu.yml) => {"ansible_facts": {"required_pkgs": ["python3-apt", "aufs-tools", "apt-transport-https", "software-properties-common", "conntrack"]}, "ansible_included_var_files": ["/builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubernetes/preinstall/vars/ubuntu.yml"], "ansible_loop_var": "item", "changed": false, "item": "/builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubernetes/preinstall/vars/../vars/ubuntu.yml"}�[0m

looks good to me

[floryut]

For my own future understanding, how would one (being me) trigger the build jobs in future?

You need to ask on slack/PR for someone to trigger it for you (as you need elevated right for this) 👍

Interesting, the job failed in bash: /usr/bin/python: No such file or directory" for check_apiserver. Hrm....

Yes the change seems fine as Ubuntu 16/18/20 looks good on playbook-end, the job error might come from ansible_interpreter not set to python3 when running tests, but why would some ubuntu18 jobs works and not one is beyond my understanding for now 😄

[floryut]

Anyhow you still could remove https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes/preinstall/vars/ubuntu-21.04.yml as there is no need for a specific vars now that both files have the same content

[Shinerrs]

Great suggestion, I have now implemented your suggestion.

[oomichi]

/ok-to-test
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Shinerrs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment