Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with api token wait check not working #7566

Merged

Conversation

floryut
Copy link
Member

@floryut floryut commented Apr 28, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
We have a looooot of test failing with centos8, all tests are failing like this https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1218002822

fatal: [instance-1]: FAILED! => {"attempts": 1, "changed": false, "cmd": "set -o pipefail && /usr/local/bin/kubectl describe serviceaccounts default --namespace test | grep Tokens | awk '{print $2}'", "delta": "0:00:00.528763", "end": "2021-04-28 08:21:48.217822", "msg": "non-zero return code", "rc": 1, "start": "2021-04-28 08:21:47.689059", "stderr": "Error from server (NotFound): serviceaccounts \"default\" not found", "stderr_lines": ["Error from server (NotFound): serviceaccounts \"default\" not found"], "stdout": "", "stdout_lines": []}

Which issue(s) this PR fixes:
Check introduce in #7045

Special notes for your reviewer:
Not sure if trying and waiting will work, but at least the test will not break on first attempt and will retry its 5 tries

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO April 28, 2021 09:20
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2021
@floryut floryut force-pushed the fix_serviceaccount_issue branch from 91f57bc to 3caff55 Compare April 28, 2021 09:54
@floryut floryut requested a review from oomichi April 30, 2021 09:11
@champtar
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit d29ea38 into kubernetes-sigs:master Apr 30, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 17, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants