Wait for available API token in a new namespace #7045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/failing-test
k8s-ci-robot
added
the
size/XS
oomichi
force-pushed
the
add-wait-for-token
branch
2 times, most recently
from
a0de285 to
8d6c108
Compare
k8s-ci-robot
added
size/S
oomichi
force-pushed
the
add-wait-for-token
branch
from
8d6c108 to
1e2d517
Compare
Just after creating a namespace, the corresponding token could not be created and sometimes the pod creation might be failed. This adds check of the token in the new namespace to make this test case stable.
oomichi
force-pushed
the
add-wait-for-token
branch
from
1e2d517 to
f732361
Compare
|
/retest |
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
floryut
approved these changes
Dec 19, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, LuckySB, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 17, 2021
Just after creating a namespace, the corresponding token could not be created and sometimes the pod creation might be failed. This adds check of the token in the new namespace to make this test case stable.
VannTen
added a commit
to VannTen/kubespray
that referenced
this pull request
Oct 25, 2024
…igs#7045)" This reverts commit 275c54e. Static tokens are no longer created automatically for service account in Kubernetes. Instead, they are dynamically injected into pods using a projected volume. Thus there is no longer a need to check for this (it didn't work anyway, since the describe output actually contains <none> when there is no tokens: { "attempts": 1, "changed": false, "cmd": "set -o pipefail && /usr/local/bin/kubectl describe serviceaccounts default --namespace test | grep Tokens | awk '{print $2}'", "delta": "0:00:00.075633", "end": "2024-10-19 14:25:04.858871", "msg": "", "rc": 0, "start": "2024-10-19 14:25:04.783238", "stderr": "", "stderr_lines": [], "stdout": "<none>", "stdout_lines": [ "<none>" ] } )
VannTen
added a commit
to VannTen/kubespray
that referenced
this pull request
Dec 12, 2024
This is a followup to 2ba28a3 (Revert "Wait for available API token in a new namespace (kubernetes-sigs#7045)", 2024-10-25). While checking for the serviceaccount token is not effective, there is still a race when creating a Pod directly, because the ServiceAccount itself might not be created yet. More details at kubernetes/kubernetes#66689. This cause very frequent flakes in our CI with spurious failures. Use a Deployment instead ; it will takes cares of creating the Pods and retrying ; it also let us use kubectl rollout status instead of manually checking for the pods.
VannTen
added a commit
to VannTen/kubespray
that referenced
this pull request
Dec 12, 2024
This is a followup to 2ba28a3 (Revert "Wait for available API token in a new namespace (kubernetes-sigs#7045)", 2024-10-25). While checking for the serviceaccount token is not effective, there is still a race when creating a Pod directly, because the ServiceAccount itself might not be created yet. More details at kubernetes/kubernetes#66689. This cause very frequent flakes in our CI with spurious failures. Use a Deployment instead ; it will takes cares of creating the Pods and retrying ; it also let us use kubectl rollout status instead of manually checking for the pods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
/kind flake
What this PR does / why we need it:
Just after creating a namespace, the corresponding token could not be created and sometimes the pod creation might be failed.
This adds check of the token in the new namespace to make this test case stable.
Which issue(s) this PR fixes:
Fixes #7043
Does this PR introduce a user-facing change?: