Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move centos7-crio CI job to centos8 #7327

Merged

Conversation

floryut
Copy link
Member

@floryut floryut commented Feb 26, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
Move centos7 crio CI job to centos8

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
CRI-O are considering removing centos7 "support", CI is broken twice a week with centos7-crio, stop this madness.

Does this PR introduce a user-facing change?:

Maybe warn users about centos7 and crio..

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2021
@floryut floryut force-pushed the centos7-crio-smoothkill branch 2 times, most recently from 6ce8995 to fdbb845 Compare February 26, 2021 16:20
@floryut floryut force-pushed the centos7-crio-smoothkill branch 6 times, most recently from cfe3536 to 4c7899b Compare February 27, 2021 21:02
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2021
@floryut floryut force-pushed the centos7-crio-smoothkill branch 4 times, most recently from 4945d39 to 6820db2 Compare February 27, 2021 21:47
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2021
@floryut floryut force-pushed the centos7-crio-smoothkill branch 3 times, most recently from a34f6b0 to f51bc8a Compare February 28, 2021 19:21
@floryut floryut marked this pull request as ready for review February 28, 2021 19:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2021
@floryut
Copy link
Member Author

floryut commented Mar 1, 2021

@champtar Ready 🎉
/cc @EppO
/cc @oomichi

@k8s-ci-robot k8s-ci-robot requested a review from oomichi March 1, 2021 15:32
@oomichi
Copy link
Contributor

oomichi commented Mar 1, 2021

@floryut Thanks for doing this. I also faced the test failure related to centos7-crio.
As we see the test success here, it is nice to move it to centos8 to make tests stable.

/lgtm

BTW is the centos8 a CentOS Linux or Stream?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit e35bece into kubernetes-sigs:master Mar 1, 2021
champtar pushed a commit to champtar/kubespray that referenced this pull request Mar 2, 2021
@floryut
Copy link
Member Author

floryut commented Mar 2, 2021

@floryut Thanks for doing this. I also faced the test failure related to centos7-crio.
As we see the test success here, it is nice to move it to centos8 to make tests stable.

/lgtm

BTW is the centos8 a CentOS Linux or Stream?

As of now still CentOS Linux

@champtar
Copy link
Contributor

champtar commented Mar 2, 2021

With the recent announcements, I wonder if it's doable to use RHEL in the CI

k8s-ci-robot pushed a commit that referenced this pull request Mar 2, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants