Update dashboard_enabled on sample #7316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
floryut
approved these changes
Feb 24, 2021
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
oomichi
force-pushed
the
update-kubernetes-dashboard
branch
from
daadc02 to
4f03821
Compare
k8s-ci-robot
removed
the
lgtm
|
To kick CI tests again after #7327 this PR has been rebased on the latest master. |
|
/retest |
Since kubernetes-sigs#6804 dashboard_enabled has been false by default. However we forgot to update it on sample inventory and it made confusion. This updates the sample inventory.
oomichi
force-pushed
the
update-kubernetes-dashboard
branch
from
4f03821 to
5b65fae
Compare
/lgtm (Again after rebase) |
k8s-ci-robot
added
the
lgtm
floryut
approved these changes
Mar 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Apr 6, 2021
Since kubernetes-sigs#6804 dashboard_enabled has been false by default. However we forgot to update it on sample inventory and it made confusion. This updates the sample inventory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Since #6804 dashboard_enabled has been false by default.
However we forgot to update it on sample inventory and it made confusion.
This updates the sample inventory.
Does this PR introduce a user-facing change?: