-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.15] roles/docker: Make repokey fingerprint overrideable #7263
[2.15] roles/docker: Make repokey fingerprint overrideable #7263
Conversation
This makes the docker role work the same as the containerd role. Being able to override this is needed when you have your own debian repository. E.g. when performing an airgapped installation
Hi @arianvp. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arianvp, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Could this be merged, please? |
Thanks for doing this. /lgtm |
/ok-to-test |
This makes the docker role work the same as the containerd role.
Being able to override this is needed when you have your own debian
repository. E.g. when performing an airgapped installation
What type of PR is this?
/kind bug
What this PR does / why we need it:
It makes sure the GPG key-id for the docker repo is overrideable. The GPG Key id might be different when e.g. doing an airgapped deploy or a deploy with a custom package repository.
Which issue(s) this PR fixes:
Fixes #6879
Special notes for your reviewer:
Backport of #7247
Does this PR introduce a user-facing change?: