roles/docker: Make repokey fingerprint overrideable #7247
Conversation
This makes the docker role work the same as the containerd role. Being able to override this is needed when you have your own debian repository. E.g. when performing an airgapped installation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @arianvp! |
|
Hi @arianvp. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XS
|
/ok-to-test please sign the CLA |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arianvp, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I have signed the CLA now. But I do not know how to retrigger the check Edit: apparently sending a message was enough :) |
k8s-ci-robot
added
cncf-cla: yes
It is indeed, thanks for the PR @arianvp |
|
Would it be possible to also get this commit on the release branch after merging? |
This is 2.15 with kubernetes-sigs/kubespray#7247 cherry-picked on top; as we need it for offline deploy. It will allow us to point the docker install playbook to an alternative package repository. Though 2.14 we never had in a release, I will still provide some upgrade instructions: To upgrade an existing cluster follow the instructions here: https://kubespray.io/#/docs/upgrades?id=graceful-upgrade ``` $ cd ansible $ ansible-playbook ./roles-external/kubespray/upgrade-cluster.yml -i ./your-inventory ``` This should guide you through the upgrade process step by step.
You'll need to create a PR to backport this on the expect branch (first 2.15 then 2.14 etc..) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This is 2.15 with kubernetes-sigs/kubespray#7247 cherry-picked on top; as we need it for offline deploy. It will allow us to point the docker install playbook to an alternative package repository. Though 2.14 we never had in a release, I will still provide some upgrade instructions: To upgrade an existing cluster follow the instructions here: https://kubespray.io/#/docs/upgrades?id=graceful-upgrade ``` $ cd ansible $ ansible-playbook ./roles-external/kubespray/upgrade-cluster.yml -i ./your-inventory ``` This should guide you through the upgrade process step by step.
* kubespray: 2.14 -> 2.15 This is 2.15 with kubernetes-sigs/kubespray#7247 cherry-picked on top; as we need it for offline deploy. It will allow us to point the docker install playbook to an alternative package repository. Though 2.14 we never had in a release, I will still provide some upgrade instructions: To upgrade an existing cluster follow the instructions here: https://kubespray.io/#/docs/upgrades?id=graceful-upgrade ``` $ cd ansible $ ansible-playbook ./roles-external/kubespray/upgrade-cluster.yml -i ./your-inventory ``` This should guide you through the upgrade process step by step.
This is 2.15 with kubernetes-sigs/kubespray#7247 cherry-picked on top; as we need it for offline deploy. It will allow us to point the docker install playbook to an alternative package repository. Though 2.14 we never had in a release, I will still provide some upgrade instructions: To upgrade an existing cluster follow the instructions here: https://kubespray.io/#/docs/upgrades?id=graceful-upgrade ``` $ cd ansible $ ansible-playbook ./roles-external/kubespray/upgrade-cluster.yml -i ./your-inventory ``` This should guide you through the upgrade process step by step.
…7247) This makes the docker role work the same as the containerd role. Being able to override this is needed when you have your own debian repository. E.g. when performing an airgapped installation
This makes the docker role work the same as the containerd role.
Being able to override this is needed when you have your own debian
repository. E.g. when performing an airgapped installation
What type of PR is this?
/kind bug
What this PR does / why we need it:
It makes sure the GPG key-id for the docker repo is overrideable. The GPG Key id might be different when e.g. doing an airgapped deploy or a deploy with a custom package repository.
Which issue(s) this PR fixes:
Fixes #6879
Special notes for your reviewer:
Does this PR introduce a user-facing change?: