[2.14] fix ci #7021

champtar · 2020-12-11T15:28:32Z

Selection of CI fixes from master

What type of PR is this?
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:
cherry-pick of many commits

Does this PR introduce a user-facing change?:

k8s-ci-robot · 2020-12-11T15:28:40Z

Hi @champtar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EppO · 2020-12-11T17:40:08Z

/ok-to-test

oomichi · 2020-12-11T23:59:51Z

/lgtm

* fix flake8 errors in Kubespray CI - tox-inventory-builder * Invalidate CRI-O kubic repo's cache Signed-off-by: Victor Morales <[email protected]> * add support to configure pkg install retries and use in CI job tf-ovh_ubuntu18-calico (due to it failing often) * Switch Calico and Cilium image repos to Quay.io Co-authored-by: Victor Morales <[email protected]> Co-authored-by: Barry Melbourne <[email protected]> Conflicts: roles/download/defaults/main.yml

EppO · 2020-12-14T14:26:16Z

looks like kubespray tries to install crio-1.17 and the molecule test is installing 1.18

(cherry picked from commit 06ec539)

(cherry picked from commit d739a6b)

* containerd docker hub registry mirror support * add docs * fix typo * fix yamllint * fix indent in sample and ansible-playbook param in testcases_run * fix md * mv common vars to tests/common/_docker_hub_registry_mirror.yml * checkout vars to upgrade tests (cherry picked from commit 4a8a52b)

If a branch name contains '.sh', current shellcheck checks the branch file under .git/ and outputs error because the format is not shell script one. This makes shellcheck exclude files under .git/ to avoid this issue. (cherry picked from commit e2467d8)

floryut · 2020-12-17T10:32:15Z

/lgtm
/approve

mattymo · 2020-12-17T13:25:37Z

docs/containerd.md

@@ -0,0 +1,31 @@
+# conrainerd


Well let's fix this in master, we don't really care in 2.14 😄

I'm just backporting master commit, can we just fix the CI and fix typo in another PR ?

typo is still in master BTW: https://github.com/kubernetes-sigs/kubespray/blob/master/docs/containerd.md

oomichi · 2020-12-17T14:13:13Z

/lgtm

LuckySB · 2020-12-17T15:23:29Z

fix typo
#7057

/approve

champtar · 2020-12-17T15:40:48Z

@LuckySB Maybe approve in an edit doesn't work ...

floryut · 2020-12-17T15:41:30Z

@LuckySB Maybe approve in an edit doesn't work ...

Yes it doesn't

Miouge1 · 2020-12-17T16:05:46Z

/approve

OWNERS are checked against the target branch. When you get added to the OWNERS file in master you get lgtm/approve access to releases from that point on, but not back in time.

k8s-ci-robot · 2020-12-17T16:05:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champtar, floryut, LuckySB, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [LuckySB,Miouge1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* [2.14] fix ci (#7021) * fix flake8 errors in Kubespray CI - tox-inventory-builder * fix flake8 errors in Kubespray CI - tox-inventory-builder * Invalidate CRI-O kubic repo's cache Signed-off-by: Victor Morales <[email protected]> * add support to configure pkg install retries and use in CI job tf-ovh_ubuntu18-calico (due to it failing often) * Switch Calico and Cilium image repos to Quay.io Co-authored-by: Victor Morales <[email protected]> Co-authored-by: Barry Melbourne <[email protected]> Conflicts: roles/download/defaults/main.yml * up vagrant box to fedora/33-cloud-base in cri-o molecule tests (cherry picked from commit 06ec539) * add Google proxy-mirror-cache for docker hub to CI tests (cherry picked from commit d739a6b) * containerd docker hub registry mirror support * containerd docker hub registry mirror support * add docs * fix typo * fix yamllint * fix indent in sample and ansible-playbook param in testcases_run * fix md * mv common vars to tests/common/_docker_hub_registry_mirror.yml * checkout vars to upgrade tests (cherry picked from commit 4a8a52b) * Exclude .git/ from shellcheck If a branch name contains '.sh', current shellcheck checks the branch file under .git/ and outputs error because the format is not shell script one. This makes shellcheck exclude files under .git/ to avoid this issue. (cherry picked from commit e2467d8) Co-authored-by: Hans Feldt <[email protected]> Co-authored-by: Sergey <[email protected]> Co-authored-by: Kenichi Omichi <[email protected]> * Switch some image from dockerhub to k8s.gcr (also increase pkg retries) (#6955) * Set packet_centos8-kube-ovn test to manual Signed-off-by: Rick Haan <[email protected]> Co-authored-by: Etienne Champetier <[email protected]> Co-authored-by: Hans Feldt <[email protected]> Co-authored-by: Sergey <[email protected]> Co-authored-by: Kenichi Omichi <[email protected]> Co-authored-by: Florian Ruynat <[email protected]>

k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2020

k8s-ci-robot requested review from floryut and holmsten December 11, 2020 15:28

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2020

k8s-ci-robot assigned oomichi Dec 11, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2020

champtar force-pushed the 2.14_fix_ci branch from ba69bdc to 6b99e31 Compare December 14, 2020 10:57

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2020

champtar changed the title ~~[2.14] fix flake8 errors in Kubespray CI - tox-inventory-builder~~ [2.14] fix ci Dec 14, 2020

champtar force-pushed the 2.14_fix_ci branch from 0b29bfc to b3b74a4 Compare December 14, 2020 18:28

up vagrant box to fedora/33-cloud-base in cri-o molecule tests

ea34801

(cherry picked from commit 06ec539)

champtar force-pushed the 2.14_fix_ci branch from b3b74a4 to ea34801 Compare December 16, 2020 16:01

LuckySB added 2 commits December 16, 2020 17:44

add Google proxy-mirror-cache for docker hub to CI tests

5baac00

(cherry picked from commit d739a6b)

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2020

Exclude .git/ from shellcheck

01e4abb

If a branch name contains '.sh', current shellcheck checks the branch file under .git/ and outputs error because the format is not shell script one. This makes shellcheck exclude files under .git/ to avoid this issue. (cherry picked from commit e2467d8)

k8s-ci-robot assigned floryut Dec 17, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020

mattymo reviewed Dec 17, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020

k8s-ci-robot merged commit d3954a5 into kubernetes-sigs:release-2.14 Dec 17, 2020

champtar deleted the 2.14_fix_ci branch December 17, 2020 16:08

RickHaan mentioned this pull request Jan 8, 2021

[2.13] Backport CI fix #7119

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2.14] fix ci #7021

[2.14] fix ci #7021

champtar commented Dec 11, 2020 •

edited

Loading

k8s-ci-robot commented Dec 11, 2020

EppO commented Dec 11, 2020

oomichi commented Dec 11, 2020

EppO commented Dec 14, 2020

floryut commented Dec 17, 2020

mattymo Dec 17, 2020

floryut Dec 17, 2020

champtar Dec 17, 2020

champtar Dec 17, 2020

champtar Dec 17, 2020

oomichi commented Dec 17, 2020

LuckySB commented Dec 17, 2020 •

edited

Loading

champtar commented Dec 17, 2020

floryut commented Dec 17, 2020

Miouge1 commented Dec 17, 2020

k8s-ci-robot commented Dec 17, 2020

[2.14] fix ci #7021

[2.14] fix ci #7021

Conversation

champtar commented Dec 11, 2020 • edited Loading

k8s-ci-robot commented Dec 11, 2020

EppO commented Dec 11, 2020

oomichi commented Dec 11, 2020

EppO commented Dec 14, 2020

floryut commented Dec 17, 2020

mattymo Dec 17, 2020

Choose a reason for hiding this comment

floryut Dec 17, 2020

Choose a reason for hiding this comment

champtar Dec 17, 2020

Choose a reason for hiding this comment

champtar Dec 17, 2020

Choose a reason for hiding this comment

champtar Dec 17, 2020

Choose a reason for hiding this comment

oomichi commented Dec 17, 2020

LuckySB commented Dec 17, 2020 • edited Loading

champtar commented Dec 17, 2020

floryut commented Dec 17, 2020

Miouge1 commented Dec 17, 2020

k8s-ci-robot commented Dec 17, 2020

champtar commented Dec 11, 2020 •

edited

Loading

LuckySB commented Dec 17, 2020 •

edited

Loading