Switch some image from dockerhub to k8s.gcr (also increase pkg retries) #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
floryut
force-pushed
the
move_away_from_dockerhub
branch
from
b880d90 to
30dac7f
Compare
floryut
changed the title
floryut
commented
Nov 26, 2020
| @@ -918,15 +916,6 @@ downloads: | |||
| groups: | |||
| - kube-master | |||
|
|
|||
| busybox: | |||
There was a problem hiding this comment.
For information, this is no longer used in kube-router since 1.x
floryut
commented
Nov 26, 2020
| @@ -489,10 +489,8 @@ nodelocaldns_image_tag: "{{ nodelocaldns_version }}" | |||
| dnsautoscaler_version: 1.8.3 | |||
| dnsautoscaler_image_repo: "{{ kube_image_repo }}/cpa/cluster-proportional-autoscaler-{{ image_arch }}" | |||
| dnsautoscaler_image_tag: "{{ dnsautoscaler_version }}" | |||
| test_image_repo: "{{ docker_image_repo }}/library/busybox" | |||
There was a problem hiding this comment.
This is used in test and we don't care about the busybox image..
EppO
reviewed
Nov 26, 2020
| @@ -479,7 +479,7 @@ haproxy_image_tag: 2.2 | |||
| # Coredns version should be supported by corefile-migration (or at least work with) | |||
| # bundle with kubeadm; if not 'basic' upgrade can sometimes fail | |||
| coredns_version: "1.7.0" | |||
| coredns_image_repo: "{{ docker_image_repo }}/coredns/coredns" | |||
| coredns_image_repo: "{{ kube_image_repo }}/coredns" | |||
There was a problem hiding this comment.
The official release repo for CoreDNS is DockerHub. I know kubeadm default is the one in gcr.io but I'm wondering what we should use, the official one or the kubeadm's.
There was a problem hiding this comment.
I guess it doesn't really matter, as long as that's part of their release process now that CoreDNS is kube default DNS stack
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Merged
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 16, 2021
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jan 21, 2021
* [2.14] fix ci (#7021) * fix flake8 errors in Kubespray CI - tox-inventory-builder * fix flake8 errors in Kubespray CI - tox-inventory-builder * Invalidate CRI-O kubic repo's cache Signed-off-by: Victor Morales <[email protected]> * add support to configure pkg install retries and use in CI job tf-ovh_ubuntu18-calico (due to it failing often) * Switch Calico and Cilium image repos to Quay.io Co-authored-by: Victor Morales <[email protected]> Co-authored-by: Barry Melbourne <[email protected]> Conflicts: roles/download/defaults/main.yml * up vagrant box to fedora/33-cloud-base in cri-o molecule tests (cherry picked from commit 06ec539) * add Google proxy-mirror-cache for docker hub to CI tests (cherry picked from commit d739a6b) * containerd docker hub registry mirror support * containerd docker hub registry mirror support * add docs * fix typo * fix yamllint * fix indent in sample and ansible-playbook param in testcases_run * fix md * mv common vars to tests/common/_docker_hub_registry_mirror.yml * checkout vars to upgrade tests (cherry picked from commit 4a8a52b) * Exclude .git/ from shellcheck If a branch name contains '.sh', current shellcheck checks the branch file under .git/ and outputs error because the format is not shell script one. This makes shellcheck exclude files under .git/ to avoid this issue. (cherry picked from commit e2467d8) Co-authored-by: Hans Feldt <[email protected]> Co-authored-by: Sergey <[email protected]> Co-authored-by: Kenichi Omichi <[email protected]> * Switch some image from dockerhub to k8s.gcr (also increase pkg retries) (#6955) * Set packet_centos8-kube-ovn test to manual Signed-off-by: Rick Haan <[email protected]> Co-authored-by: Etienne Champetier <[email protected]> Co-authored-by: Hans Feldt <[email protected]> Co-authored-by: Sergey <[email protected]> Co-authored-by: Kenichi Omichi <[email protected]> Co-authored-by: Florian Ruynat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
We need to implement a more permanent solution, in the meantime this will reduce pull from dockerhub
Which issue(s) this PR fixes:
None but this will reduce the pulls from dockerhub by 5 for each CI jobs, reducing the docker rate limit error
Special notes for your reviewer:
I also commented the
dashboard_enabledso that it's not downloaded on each CI job and enable it only in one (the one where we changed the dashboard NS)Does this PR introduce a user-facing change?: